Skip to content

fix(imitation): skip pose lookup during collection - #3296

Draft
ruthwikdasyam wants to merge 1 commit into
mainfrom
ruthwik/fix/imitation-frame-id-spam
Draft

fix(imitation): skip pose lookup during collection#3296
ruthwikdasyam wants to merge 1 commit into
mainfrom
ruthwik/fix/imitation-frame-id-spam

Conversation

@ruthwikdasyam

Copy link
Copy Markdown
Contributor

Contribution path

  • Small, safe change that does not need a tracking issue

Problem

Imitation collection streams do not use stored spatial poses, but the memory2 recorder still attempted frame and TF lookups for every message. This produced repeated missing-pose warnings and unnecessary TF recording work.

Solution

  • Skip pose resolution entirely for recorder streams configured as poseless.
  • Mark imitation image, joint-state, and episode-status streams as poseless.
  • Disable unused TF recording in both imitation collection blueprints.
  • Add regression coverage for the recorder behavior and blueprint configuration.

How to Test

uv run pytest dimos/memory2/test_module.py dimos/imitation dimos/codebase_checks/test_blueprint_kwargs.py

Simulation smoke test: dimos --simulation run learning-collect-quest-xarm7

AI assistance

OpenCode with GPT-5.6 Sol reviewed the collection and dataprep pipeline, implemented this focused change, resolved the main-branch integration conflict, and ran the checks. Human review is pending.

Checklist

  • I have read and approved the CLA.

@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
dimos/memory2/module.py 50.00% 0 Missing and 1 partial ⚠️
@@           Coverage Diff           @@
##             main    #3296   +/-   ##
=======================================
  Coverage   74.86%   74.87%           
=======================================
  Files        1137     1138    +1     
  Lines      109071   109090   +19     
  Branches     9838     9839    +1     
=======================================
+ Hits        81661    81679   +18     
  Misses      24618    24618           
- Partials     2792     2793    +1     
Flag Coverage Δ
OS-ubuntu-24.04-arm 68.69% <95.00%> (-0.01%) ⬇️
OS-ubuntu-latest 70.79% <95.00%> (+<0.01%) ⬆️
Py-3.10 70.79% <95.00%> (+<0.01%) ⬆️
Py-3.11 70.79% <95.00%> (-0.01%) ⬇️
Py-3.12 70.79% <95.00%> (+<0.01%) ⬆️
Py-3.13 70.79% <95.00%> (+<0.01%) ⬆️
Py-3.14 70.79% <95.00%> (-0.01%) ⬇️
Py-3.14t 70.79% <95.00%> (-0.01%) ⬇️
SelfHosted-Large 29.17% <45.00%> (+0.13%) ⬆️
SelfHosted-Linux 35.89% <45.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
dimos/imitation/collection/blueprint.py 88.88% <ø> (ø)
dimos/imitation/collection/test_blueprint.py 100.00% <100.00%> (ø)
dimos/memory2/test_module.py 93.75% <100.00%> (+1.25%) ⬆️
dimos/memory2/module.py 42.79% <50.00%> (+0.06%) ⬆️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant