fix(imitation): skip pose lookup during collection - #3296
Draft
ruthwikdasyam wants to merge 1 commit into
Draft
Conversation
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #3296 +/- ##
=======================================
Coverage 74.86% 74.87%
=======================================
Files 1137 1138 +1
Lines 109071 109090 +19
Branches 9838 9839 +1
=======================================
+ Hits 81661 81679 +18
Misses 24618 24618
- Partials 2792 2793 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution path
Problem
Imitation collection streams do not use stored spatial poses, but the memory2 recorder still attempted frame and TF lookups for every message. This produced repeated missing-pose warnings and unnecessary TF recording work.
Solution
How to Test
uv run pytest dimos/memory2/test_module.py dimos/imitation dimos/codebase_checks/test_blueprint_kwargs.pySimulation smoke test:
dimos --simulation run learning-collect-quest-xarm7AI assistance
OpenCode with GPT-5.6 Sol reviewed the collection and dataprep pipeline, implemented this focused change, resolved the main-branch integration conflict, and ran the checks. Human review is pending.
Checklist