feat(manipulation): simplify RoboPlan joint paths - #3325
Open
TomCC7 wants to merge 5 commits into
Open
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #3325 +/- ##
==========================================
+ Coverage 75.46% 75.48% +0.02%
==========================================
Files 1157 1157
Lines 111276 111390 +114
Branches 10073 10078 +5
==========================================
+ Hits 83971 84085 +114
- Misses 24417 24418 +1
+ Partials 2888 2887 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
TomCC7
commented
Aug 2, 2026
TomCC7
marked this pull request as ready for review
August 2, 2026 02:17
TomCC7
requested review from
Dreamsorcerer,
leshy,
mustafab0,
paul-nechifor and
spomichter
as code owners
August 2, 2026 02:17
TomCC7
enabled auto-merge
August 2, 2026 02:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution path
Problem
RoboPlan returns valid native joint-space RRT paths without applying its optional collision-aware shortcutting pass. The DimOS adapter did not expose the shortcutting settings, so users could not enable, tune, or disable path simplification through planner configuration.
Solution
Configure RoboPlan path shortcutting on the existing
RoboPlanWorldclass and apply it before converting native paths to DimOS joint states.planner.path_shortcutting.PathShortcuttingOptions.The implementation keeps the existing planner class and runs shortcutting under the scene lock used by native planning.
How to Test
uv run dimos run dual-xarm6-planner-coordinatorand see how path got simpler nowAI assistance
OpenAI Codex with GPT-5 assisted substantially with implementation, unit tests, review cleanup, and PR text.
Checklist