Repository navigation
Admin: Keep the account at the right of the header in every layout - #449
Merged
Merged
Conversation
- The sidebar takes the free room up to the window edge, and its docked panels keep their width of up to 360px next to the page - The account and the Sign In button sit next to the sidebar's toggle, whose room stays reserved in views without panels, so they don't move while the sidebar slides, on wide pages or between views - Notifications show at the window's right edge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The account and the Sign In button used to sit at the start of the sidebar's header, so they moved while the sidebar slid, jumped between normal and wide pages, and between views with and without panels.
useSidebar()keeps the sidebar growing while it animatesDitoTrigger'splacementcan center popups, e.g.'bottom-center', whichkeepInViewshifts back into the window, exposing the shift as--dito-popup-shiftsoDitoMenuButton's tip keeps pointing at the button. The account's menu opens centered below it.A new e2e spec tracks the account's position in every frame while the sidebar collapses, expands and the view changes, at 1600 and 900px. It fails without the change.