Detect scanned QR sync codes - #9333
Merged
Merged
Conversation
This was referenced Jul 29, 2026
Contributor
Author
9 tasks
MiSikora
force-pushed
the
feature/mehow/simple-sync/detect-scanned-code
branch
from
July 29, 2026 12:20
9170a30 to
faaaf23
Compare
This was referenced Jul 29, 2026
MiSikora
force-pushed
the
feature/mehow/simple-sync/detect-scanned-code
branch
2 times, most recently
from
July 30, 2026 12:10
efdd0e2 to
93146eb
Compare
MiSikora
force-pushed
the
feature/mehow/simple-sync/manual-entry-ui
branch
from
July 30, 2026 12:10
df99fd8 to
6284013
Compare
MiSikora
changed the base branch from
feature/mehow/simple-sync/manual-entry-ui
to
graphite-base/9333
July 30, 2026 12:41
MiSikora
force-pushed
the
graphite-base/9333
branch
from
July 30, 2026 12:59
6284013 to
c14ae3d
Compare
MiSikora
force-pushed
the
feature/mehow/simple-sync/detect-scanned-code
branch
from
July 30, 2026 12:59
05629b6 to
9b554ef
Compare
MiSikora
force-pushed
the
feature/mehow/simple-sync/detect-scanned-code
branch
2 times, most recently
from
July 31, 2026 04:49
41fbdeb to
9df052d
Compare
This was referenced Jul 31, 2026
CDRussell
reviewed
Aug 3, 2026
MiSikora
force-pushed
the
feature/mehow/simple-sync/detect-scanned-code
branch
from
August 3, 2026 12:44
9df052d to
08fc11a
Compare
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 08fc11a. Configure here.
CDRussell
approved these changes
Aug 3, 2026
MiSikora
force-pushed
the
feature/mehow/simple-sync/detect-scanned-code
branch
from
August 3, 2026 16:30
463e15b to
b35588b
Compare
MiSikora
force-pushed
the
feature/mehow/simple-sync/detect-scanned-code
branch
from
August 4, 2026 07:11
b35588b to
5cccd63
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1216422585541213?focus=true
Tech Design URL (if applicable): https://app.asana.com/1/137249556945/project/72649045549333/task/1216509582049467?focus=true
API Proposals URL(s) (if applicable): N/A
Description
Detects and handles QR codes scanned with the camera on the "Scan QR" tab of the simplified Sync With Another Device screen, and adds basic validation of scanned and pasted codes.
Steps to test this PR
Scan a valid sync code
Scan an invalid code
Paste an invalid code
UI changes
N/A
Note
Medium Risk
Changes sync pairing entry points (camera scan and paste) in v2 UI; incorrect handling could start sync with bad data or spam launches, though scope is limited to the read-sync-code screen.
Overview
Wires the Scan QR camera tab so decoded barcodes flow through
ReadSyncCodeViewModeland launch the existingExchangeSyncCodeflow with the scanned text. Decoding runs while the fragment is resumed (with optional QR-only decoding whenrestrictScannedBarcodesToQrTypesis enabled) and stops when the lifecycle pauses.Paste validation is tightened: blank clipboard content shows a snackbar via a new
ShowMessagecommand instead of starting sync. The activity handles that command with aSnackbar.Adds user-facing strings for invalid scanned/pasted codes (scanned invalid message is in resources; paste path uses it).
ExchangeSyncCodeActivityuses the generic sync screen title. ViewModel tests cover scan, paste, and blank paste.Reviewed by Cursor Bugbot for commit 5cccd63. Bugbot is set up for automated code reviews on this repo. Configure here.