Clean up sync code before integrating pixels - #9386
Open
MiSikora wants to merge 11 commits into
Open
Conversation
This was referenced Aug 4, 2026
Contributor
Author
6 tasks
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 364877f. Configure here.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The screen and its collaborators handle any sync code type and drive the sync protocol to completion, so "Exchange" was misleading (it also collided with the exchange-code concept). Renames the activity, view model, contract, layout, animation and their references. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
MiSikora
force-pushed
the
feature/mehow/simple-sync/rename-race-condition
branch
from
August 4, 2026 15:15
288957a to
e789f61
Compare
MiSikora
force-pushed
the
feature/msikora/simple-sync/pixels-cleanup
branch
from
August 4, 2026 15:15
364877f to
86731db
Compare
MiSikora
force-pushed
the
feature/msikora/simple-sync/pixels-cleanup
branch
from
August 4, 2026 15:20
86731db to
6869120
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Task/Issue URL: https://app.asana.com/1/137249556945/project/1216103556496795/task/1217108453800380?focus=true
Tech Design URL (if applicable): N/A
API Proposals URL(s) (if applicable): N/A
Description
Pure refactor of the simplified Sync v2 setup flows. It renames types, parameters, and activity launchers so their names describe what they actually represent, and tidies up input creation. There are no behavior changes.
Sync entry point:
OriginalFlowenum is renamed toSyncEntryPointand moved to its own file, because it identifies which entry point the setup started from rather than an "original flow".SYNC_THIS_DEVICEbecomesSYNC_NEW_ACCOUNT(create and back up a new account) andSYNC_WITH_ANOTHERbecomesADD_DEVICE(add a device to an existing account).RECOVER_SYNCED_DATAis unchanged.Process sync code screen:
ExchangeSyncCodeActivityand its contract, view model, layout, and animation are renamed toProcessSyncCode*. "Exchange" was confusing since Sync also has exchange codes, whereas this part of the flow is about processing an input code, so "Process" is clearer.Parameters and launchers:
syncUrlis renamed tosyncCode, because the value is not always a URL.sourceis renamed tolaunchSourceto disambiguate it from other "source" concepts.SyncActivityare renamed to match what they launch, for examplesyncThisDeviceLauncherbecomesbackUpNewAccountLauncherandexchangeSyncCodeLauncherbecomesprocessSyncCodeLauncher.syncCodesits next tosyncEntryPointandlaunchSourcecomes last, launcher input creation is written consistently, and an unused import is removed.Steps to test this PR
N/A
UI changes
N/A
Note
Low Risk
Naming and structural refactor across sync UI with tests updated; no auth or sync protocol logic changes described beyond renames.
Overview
Refactors simplified Sync v2 setup naming so entry points, parameters, and screens read clearly before pixel work—no intended behavior changes.
Entry point model:
OriginalFlowbecomesSyncEntryPointin its own file, with valuesSYNC_NEW_ACCOUNT,ADD_DEVICE, andRECOVER_SYNCED_DATA. Auto-restore pixel source mapping moves toSyncEntryPoint.toAutoRestorePixelSource()(replacing duplicated helpers).Process sync code screen:
ExchangeSyncCodeActivity/ contract / VM / layout / animation are renamed toProcessSyncCode*, and intent extras usesyncCodeinstead ofsyncUrl.Parameters & launchers:
source→launchSource,originalFlow→syncEntryPointacross v2 activities and contracts; v2SyncActivityrenames launchers (e.g.backUpNewAccountLauncher,processSyncCodeLauncher) and aligns contractInputfield order.Reviewed by Cursor Bugbot for commit b109e98. Bugbot is set up for automated code reviews on this repo. Configure here.