Repository navigation
Sheets follow a new Appearance at once - #310
Merged
Merged
Conversation
Each sheet applies the Appearance itself; iOS presents a sheet on its own, and one that only inherits the window's look kept the old one. Assisted-by: Claude Code:claude-opus-5-5 Claude-Session: https://claude.ai/code/session_01S6amVoNeB4GahnMMe79dZ6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #252.
Eric, on iPhone (v0.1.18): changing Settings > Recording > Appearance changed the record screen behind, but the Settings sheet kept the old look until it was closed.
Cause: the Appearance (
AppearanceRoot:preferredColorSchemeplus theappearanceModeenvironment) was applied only at each window's root. iOS presents a sheet on its own, and a sheet that only inherits the window's look keeps the old one until it's shown again.Fix: every sheet applies
AppearanceRoot(mode: model.appearance)to its own content. That covers Settings, Markers, Show, Shows, Channel names, the Trial, the paywall and the delete sheets, including sheets opened from inside other sheets../scripts/verify.shpasses. Not checked on screen: I can't change the Appearance in the Simulator from here. Please try it in the next TestFlight build: Settings > Appearance > Dark, and Settings itself should turn dark at once. The rest of #252 (sheets drawing in the Sunlight palette) isn't in this PR.https://claude.ai/code/session_01S6amVoNeB4GahnMMe79dZ6