Skip to content

Raycast: address second Store review round - #19

Merged
fatwang2 merged 4 commits into
mainfrom
claude/project-thread-k88liz
Nov 3, 2026
Merged

fatwang2 merged 4 commits into
mainfrom
claude/project-thread-k88liz

Conversation

@fatwang2

@fatwang2 fatwang2 commented Nov 3, 2026

Copy link
Copy Markdown
Owner

Fixes the second automated review on raycast/extensions#33098 (confidence 4/5, 5 findings).

  • P1: list-row prices no longer fail silently. Rows that priced stay; a toast names the source that failed (Yahoo Finance or Binance) with Retry. If nothing priced, the request fails and the hook's toast offers Retry.
  • A typed ticker with a known Yahoo suffix (7203.T, 0700.HK, .SS, .SZ, .KS, .KQ, .TW, .TWO) belongs to that market, so its market filter keeps the direct lookup.
  • validCatalog checks every security and coin entry, so a malformed export never replaces the working copy. New test covers it.
  • Symbol-list errors use failureToastOptions (built-in Retry) instead of a hand-built toast.
  • Copy Symbol is the second action, so its unused custom shortcut is removed.

Checks: npm test (17 pass), npm run lint, npm run build.


Generated by Claude Code

- Move contributor notes (AGENTS.md, Development, Releasing) out of raycast/ to docs/raycast.md
- Drop the redundant command subtitle; declare macOS as the platform
- Unique temp file per catalog write
- A typed ^ ticker is an index, so the Indices filter keeps it
- Retry action on the symbol-list failure toast; Show/Hide Chart in its own section

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DuYf7vdDtMHbY6YTKJrEqJ
- List rows: keep the rows that priced, and say which source failed with a Retry
- A typed ticker with a known suffix (7203.T, 0700.HK) belongs to that market's filter
- Validate catalog entries before replacing the copy in hand, with a malformed-export test
- Use the hook's failureToastOptions instead of a hand-built toast
- Copy Symbol is the second action, so it carries no custom shortcut

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DuYf7vdDtMHbY6YTKJrEqJ
…to claude/project-thread-k88liz

# Conflicts:
#	raycast/src/search-symbol.tsx
ray publish updates the open Store submission only from the machine that holds
its fork clone; a CI runner starts from scratch each time and replaced the
submission PR (raycast/extensions#33095 -> #33098). Document the Mac mini
command instead.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DuYf7vdDtMHbY6YTKJrEqJ
@fatwang2
fatwang2 merged commit 96a4ad9 into main Nov 3, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants