Repository navigation
fix: pin hts-sys 2.2.0 and turn off the release-plz semver check - #148
Merged
Merged
Conversation
hts-sys 2.2.1 changed bindings that rust-htslib 0.46 relies on, so any resolution not pinned by Cargo.lock (cargo install, cargo-semver-checks) fails to compile rust-htslib. Pin hts-sys to the 2.2.0 the lockfile already held until rust-htslib is bumped. cargo-semver-checks also builds the published baseline crate from a fresh resolution. The 0.13.0 crate on crates.io still has vergen-git2 1.x, which no longer resolves against vergen 9.1.0, so the check can never pass for that baseline. Turn it off; conventional-commit bumping is what we rely on.
mrvollger
added a commit
that referenced
this pull request
Sep 18, 2026
#148 placed `semver_check = false` after the molecular-annotation `[[package]]` header, so it applied to that crate only. release-plz still ran cargo-semver-checks for fibertools-rs and failed on the published 0.13.0 baseline, exactly as #148 predicted for a check that is on (run 35359879404). Moves the key into `[workspace]`. Merging this is a push, so release-plz runs again and should open the 0.13.1 release PR. Co-authored-by: Mitchell R. Vollger <mvollger@gmail.com>
mrvollger
pushed a commit
that referenced
this pull request
Sep 18, 2026
## 🤖 New release * `fibertools-rs`: 0.13.0 -> 0.13.1 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.13.1](v0.13.0...v0.13.1) - 2026-09-18 ### Fixed - pin hts-sys 2.2.0 and turn off the release-plz semver check ([#148](#148)) - bump vergen-git2 to 9.1 so a fresh resolution builds again ([#146](#146)) - ft call-peaks --haps fills the H1/H2 columns ([#142](#142)) ### Other - put semver_check = false in the [workspace] table ([#150](#150)) - support patch releases from release/** branches ([#143](#143)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mrvollger
added a commit
that referenced
this pull request
Sep 18, 2026
Twin of #148 for main, rebased onto #147 so the two do not conflict on the release-plz.toml comment. Merging this brings in #147's commit too; #147 can then be closed as included. Same content as #148 plus the fix from #150: `semver_check = false` lives in the `[workspace]` table. **Do not merge until #132 (the 0.13.1 release PR on `release/v0.13`) is merged.** release-plz finds its open release PR by branch prefix only. A push to main with the semver check off would run release-plz-pr, find #132 by its `release-plz-` branch name, and force-push 0.14.0 content onto it. Today the only thing preventing that is main's run dying in the semver check, which this PR removes. After #132: merge this first on main, then #141 and #138. release-plz then opens a fresh 0.14.0 release PR. --------- Co-authored-by: Mitchell R. Vollger <mvollger@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second layer under #146. release-plz still failed to open the 0.13.1 release PR, this time inside
rust-htslib:Cause
hts-sys2.2.1 changed bindings thatrust-htslib0.46 relies on. OurCargo.lockpins 2.2.0, so locked builds pass. A fresh resolution picks 2.2.1 and fails. This is the same error #127 hit on Read the Docs, socargo install fibertools-rswithout--lockedhas been broken since 2.2.1 was published.Fix
hts-sys = "=2.2.0"as a direct dependency untilrust-htslibis bumped. The lockfile gains one edge and nothing else changes.semver_check = false. cargo-semver-checks builds the published 0.13.0 baseline the same fresh way, and that crate on crates.io still hasvergen-git21.x, so no change here can make it pass. Neither cargo-semver-checks nor release-plz has a way to honor a lockfile. The comment inrelease-plz.tomlexplains this.Check
On stable 1.98.1: a scratch crate that depends on this tree with no lockfile passes
cargo check(whatcargo installdoes), andcargo build --release --lockedpasses withft --versionstill printing the git commit.