Fix gen:mail --markdown type error and accept HtmlString content in Mailer - #4
Merged
Merged
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: huangdijia <8337659+huangdijia@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix markdown command generation error and htmlString issue
Fix Sep 11, 2026
gen:mail --markdown type error and accept HtmlString content in Mailer
huangdijia
marked this pull request as ready for review
September 12, 2026 08:10
huangdijia
approved these changes
Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gen:mail --markdowncould return a boolean fromgetView()and crash during template path generation. Separately,Content(htmlString: ...)flowed intoMailer::addContent()asHtmlStringand failed strict parameter typing.Markdown mail generator correctness
--markdownso markdown generation usesmarkdown-mail.stub.getView()to always derive a string view name when the option is a boolean flag.buildClass()markdown branch check with flag semantics.HtmlStringsupport through mail rendering pipelineMailertype signatures inparseView(),addContent(), andrenderView()to acceptHtmlString/Htmlable.Content(htmlString: ...).Example (now accepted without type error):