Repository navigation
Support completion edits in text controls - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Text controls need to replace the identifier at the caret without replacing the whole draft or losing focus. Add
Node::replace_rangewith grapheme-boundary and edit-limit validation, and exposeon:selectfor caret and selection changes.Dispatch
keydownbefore Tab traversal so completion menus can accept a suggestion. Place the caret on mouse clicks using the rendered content box and retained scroll offsets. The existing consumer contract exercises replacement, Unicode boundaries, limits, default Tab traversal, and pointer placement.Validation:
just check(formatting, workspace tests, Clippy, documentation, consumer contracts, generated starter, package archives, and Rust 1.85).This supplies the editor APIs used by SQL Bomb's in-process SQL completion. The patch contains only the editor changes and their contract documentation; net +194 lines.