Repository navigation
Add SQL completion and the boom command - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typing SQL suggests tables and columns from the active connection. A separate
sql-bomb-completioncrate uses Tree-sitter to resolve qualified names and aliases and returns edits for the identifier at the caret. The HTML suggestion list supports arrows, Tab, mouse acceptance, and Escape; Enter remains a newline.QueryClient::tables()discovery and Flight SQLCommandGetTableswith Arrow schemas. Cache metadata per connection, cancel stale discovery on connection changes, and expose refresh and failure status without blocking the editor.sql-bomband expose the executable asboom, including installation and release packaging. Organize the README around the shared workspace and separate client settings.Depends on fusor-rs/hypercmd#1. Both Hypercmd dependencies are pinned to its pushed commit
a910ab9e084df3e352e620b422d177fd0f6d75da; no local Cargo patch or absolute checkout path is required.Validation:
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --locked -- -D warningscargo test --workspace --locked— nine tests passed, including the real Flight SQL service and native terminal interaction.cargo install --path . --locked --debug --root /private/tmp/sql-bomb-pr-install, then installedboom --help.sh -n install.shandgit diff --check.cargo build --locked --release --target aarch64-apple-darwin --bin boom; release archive/checksum installation into a path with spaces, installedboom --help, and corrupted-archive rejection preserving the installed binary.Net change: +1,913 lines, including tests and the lockfile.