Skip to content

Add SQL completion and the boom command - #1

Merged
andreespirela merged 1 commit into
mainfrom
codex/sql-completion
Oct 4, 2026
Merged

andreespirela merged 1 commit into
mainfrom
codex/sql-completion

Conversation

@andreespirela

@andreespirela andreespirela commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Typing SQL suggests tables and columns from the active connection. A separate sql-bomb-completion crate uses Tree-sitter to resolve qualified names and aliases and returns edits for the identifier at the caret. The HTML suggestion list supports arrows, Tab, mouse acceptance, and Escape; Enter remains a newline.

  • Add optional QueryClient::tables() discovery and Flight SQL CommandGetTables with Arrow schemas. Cache metadata per connection, cancel stale discovery on connection changes, and expose refresh and failure status without blocking the editor.
  • Keep suggestions out of comments and strings, preserve quoted identifiers and surrounding SQL, and bound the visible list. CTE-derived columns, subquery projections, and set-operation columns remain unsupported.
  • Keep the project name sql-bomb and expose the executable as boom, including installation and release packaging. Organize the README around the shared workspace and separate client settings.

Depends on fusor-rs/hypercmd#1. Both Hypercmd dependencies are pinned to its pushed commit a910ab9e084df3e352e620b422d177fd0f6d75da; no local Cargo patch or absolute checkout path is required.

Validation:

  • cargo fmt --all -- --check
  • cargo clippy --workspace --all-targets --locked -- -D warnings
  • cargo test --workspace --locked — nine tests passed, including the real Flight SQL service and native terminal interaction.
  • cargo install --path . --locked --debug --root /private/tmp/sql-bomb-pr-install, then installed boom --help.
  • sh -n install.sh and git diff --check.
  • cargo build --locked --release --target aarch64-apple-darwin --bin boom; release archive/checksum installation into a path with spaces, installed boom --help, and corrupted-archive rejection preserving the installed binary.
  • The completion regression and terminal interaction were verified to fail without their implementation.

Net change: +1,913 lines, including tests and the lockfile.

@andreespirela
andreespirela merged commit c648f0d into main Oct 4, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant