Unified: Include short-circuiting compound assignments. - #22619
Merged
Merged
Conversation
aschackmull
added
the
no-change-note-required
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The operator additions correctly activate the existing short-circuit CFG handling without introducing unresolved issues.
Review effort: Balanced
Findings: None
What changed in this PR
Extends unified assignment modeling to recognize short-circuiting compound assignments.
Changes:
- Adds
&&=,||=, and??=toCompoundAssignExpr. - Makes
AssignmentImplprivate while retaining its public alias.
| File | Description |
|---|---|
unified/ql/lib/codeql/unified/internal/AstExtra.qll |
Expands compound-assignment recognition and encapsulates its implementation class. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
asgerf
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small followup for #22595