Skip to content

Unified: Include short-circuiting compound assignments. #22619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aschackmull merged 1 commit into from
Sep 18, 2026
+5 −2
Merged

Unified: Include short-circuiting compound assignments. #22619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions unified/ql/lib/codeql/unified/internal/AstExtra.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ private import codeql.unified.internal.NameBindingPlugin

module Public {
/** An assignment, possibly a compound assignment. */
abstract class AssignmentImpl extends BinaryExpr {
abstract private class AssignmentImpl extends BinaryExpr {
/** Gets the target of this assignment. */
abstract Expr getTarget();

Expand All @@ -30,7 +30,10 @@ module Public {
final class CompoundAssignExpr extends BinaryExpr, AssignmentImpl {
CompoundAssignExpr() {
this.getOperator().getValue() =
["+=", "-=", "*=", "/=", "%=", "<<=", ">>=", "&=", "|=", "^=", "&+=", "&-=", "&*="]
[
"+=", "-=", "*=", "/=", "%=", "<<=", ">>=", "&=", "|=", "^=", "&+=", "&-=", "&*=", "&&=",
"||=", "??="
]
}

override Expr getTarget() { result = this.getLeft() }
Expand Down
Loading