Skip to content

feat: expose markerColor and zIndex on Marker - #118

Merged
jkasprzyk17 merged 1 commit into
gmi-software:mainfrom
TayfurYldz:feat/96-marker-color-zindex
Sep 18, 2026
Merged

jkasprzyk17 merged 1 commit into
gmi-software:mainfrom
TayfurYldz:feat/96-marker-color-zindex

Conversation

@TayfurYldz

@TayfurYldz TayfurYldz commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • expose markerColor and zIndex on the <Marker> child API
  • forward both props into the collected MarkerDescriptor without adding defaults
  • add focused collector regression coverage and document the marker props

Closes #96

Validation

  • behavioral regression proof before fix: styled marker collector received undefined for markerColor
  • targeted collector tests: 2 pass, 0 fail
  • bun run --filter react-native-better-maps test: 165 pass, 0 fail
  • bun run nitrogen
  • bun run typecheck
  • bun run lint
  • git diff --check

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 56 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: e49c899a-a347-4185-828c-22008d262295

📥 Commits

Reviewing files that changed from the base of the PR and between e77b8e2 and 4233de7.

📒 Files selected for processing (6)
  • README.md
  • package/src/hooks/useCollectedOverlays.ts
  • package/src/native/specs/overlays.ts
  • package/src/overlays/__tests__/collectMarkerOverlay.test.ts
  • package/src/overlays/collectMarkerOverlay.ts
  • package/src/types/overlays.ts

Comment @coderabbitai help to get the list of available commands.

@jkasprzyk17 jkasprzyk17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TayfurYldz, nice to see this PR. The markerColor / zIndex wiring looks good. No invented defaults, omitted props stay undefined, and the README table is updated.

One change before merge: collectMarkerOverlay shouldn't be exported from useCollectedOverlays.ts. Overlay collectors already live in package/src/overlays/ (collectGeojsonOverlays is the pattern). Move the function there, keep a one-line call in the hook, and put the test in overlays/__tests__/. Then we can drop hooks/__tests__/ and the mock.module / dynamic import. That's only there because the test is going through a hook module.

Small nit: on MarkerProps, zIndex sits next to markerColor; on MarkerDescriptor it's after opacity. Matching that order would be nicer.

@TayfurYldz
TayfurYldz force-pushed the feat/96-marker-color-zindex branch from a98dff9 to 4233de7 Compare September 18, 2026 11:26
@TayfurYldz

Copy link
Copy Markdown
Contributor Author

Addressed the requested structure change in 4233de7: collectMarkerOverlay now lives under src/overlays/, the hook delegates to it, and the regression moved to overlays/__tests__ with no module mock or dynamic import. I also aligned MarkerDescriptor.zIndex next to markerColor as noted.

Validation: package tests 165/165 passed, typecheck passed, ESLint passed, build passed, and git diff --check is clean.

@jkasprzyk17 jkasprzyk17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow-up — this addresses the review feedback.

collectMarkerOverlay now lives under src/overlays/, the hook only delegates, the regression sits in overlays/__tests__/ without module mocks, and MarkerDescriptor.zIndex is aligned next to markerColor. Looks good to merge from my side.

@jkasprzyk17
jkasprzyk17 merged commit 0241a0c into gmi-software:main Sep 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add markerColor and zIndex to the <Marker> child

2 participants