feat: expose markerColor and zIndex on Marker - #118
Conversation
|
Warning Review limit reachedNext included review available in 56 minutes. View limit detailsLimit details: You’ve used the included review currently available. This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (6)
Comment |
jkasprzyk17
left a comment
There was a problem hiding this comment.
Thanks @TayfurYldz, nice to see this PR. The markerColor / zIndex wiring looks good. No invented defaults, omitted props stay undefined, and the README table is updated.
One change before merge: collectMarkerOverlay shouldn't be exported from useCollectedOverlays.ts. Overlay collectors already live in package/src/overlays/ (collectGeojsonOverlays is the pattern). Move the function there, keep a one-line call in the hook, and put the test in overlays/__tests__/. Then we can drop hooks/__tests__/ and the mock.module / dynamic import. That's only there because the test is going through a hook module.
Small nit: on MarkerProps, zIndex sits next to markerColor; on MarkerDescriptor it's after opacity. Matching that order would be nicer.
a98dff9 to
4233de7
Compare
|
Addressed the requested structure change in Validation: package tests 165/165 passed, typecheck passed, ESLint passed, build passed, and |
jkasprzyk17
left a comment
There was a problem hiding this comment.
Thanks for the follow-up — this addresses the review feedback.
collectMarkerOverlay now lives under src/overlays/, the hook only delegates, the regression sits in overlays/__tests__/ without module mocks, and MarkerDescriptor.zIndex is aligned next to markerColor. Looks good to merge from my side.
Summary
markerColorandzIndexon the<Marker>child APIMarkerDescriptorwithout adding defaultsCloses #96
Validation
undefinedformarkerColorbun run --filter react-native-better-maps test: 165 pass, 0 failbun run nitrogenbun run typecheckbun run lintgit diff --checkNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.