Repository navigation
Fix configuration metadata in stitched restart output - #2521
Open
AdemVessell wants to merge 1 commit into
Open
AdemVessell wants to merge 1 commit into
AdemVessell wants to merge 1 commit into
Conversation
AdemVessell
force-pushed
the
codex/restart-config-provenance
branch
from
November 15, 2026 09:26
5f54712 to
7ec22ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks @jcitrin for taking the time to reproduce this and for the encouraging response in #2520. I appreciated the clear guidance on what would be useful here, and I'm glad to contribute this fix.
Stitched restarts currently retain the original file's
configattribute, losing the resumed run's configuration. This change keeps the resumed configuration inconfigand saves the prior file's configuration asprevious_config.previous_configdescribes the immediately preceding run, not a complete history of chained restarts. It is omitted if the prior file lacksconfig. The change is confined to the stitching boundary; time concatenation and overlap handling are unchanged. The output documentation describes these attributes.Validation on upstream base
b53645a, macOS 27.0.1 arm64 / Python 3.12.13:TORAX_ERRORS_ENABLED=1andTORAX_JAXTYPING=1; all 8 output-key tests also pass.output_stitch_test.pybecause upstream refactored the original output test file. Production behavior remains the same as the earlier patch.The earlier 12-shard Ubuntu/Python 3.12 CI pass belongs to
5f547126; it does not validate this updated revision. The full repository suite and Linux CI for the updated head have not been run locally. Code and test preparation were AI-assisted with Codex.