Repository navigation
Fix CI site build step that never ran - #39
Merged
Merged
Conversation
The "Build tagtraum site" step in build-and-test.yml was conditioned on matrix.os (not a matrix key) and Java 9 (not in the matrix), so it never ran. Run it once per build, on the x86_64/Java 8 entry, mirroring the tagtraum publishing job. Use the site phase so the Doxygen C-Docs are generated, install Doxygen for that entry only, and check that the C-Docs exist, since the Doxygen call itself does not fail the build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The "Build tagtraum site" step in
build-and-test.ymlnever ran. Its condition wasbut
osis not a key in the macOS job's matrix, and9isn't in thejavalist. So CI never checked that the site builds. (The step also used thesite:sitegoal, which skips the Doxygen execution bound to thesitephase; see #37.)Change
The site build now runs once per CI run, on the x86_64 / Java 8 matrix entry. That mirrors the real "Publish to tagtraum" job in
deploy.yml, which builds the site with the x86_64 profile under Java 8.sitephase withffsampledsp-${{ matrix.jarch }}-macos, reusing the artifacts from the preceding build step instead ofclean installagain. Before, the profile was hard-coded toaarch64even though the condition selected x86_64.target/site/doxygen/index.htmlis missing, because the Doxygen call itself usesfailonerror="false"and would otherwise fail silently.Testing
mvn siteafterinstallbuilds all 4 modules' sites and generatestarget/site/doxygen/index.html.Not changed here: the "Upload CodeCov Report" step right above has the same never-true condition (
matrix.os == 'macos-15' && matrix.java == '9'). Re-enabling it would start uploading to Codecov (with the oldcodecov-action@v2), so I left that as a separate decision.🤖 Generated with Claude Code