Repository navigation
Publications draft: always list the Review tab, and say how to finish (supersedes #1930) - #1940
Merged
Merged
Conversation
…blication submission process
Rework of the previous commit, which added only a language string while the behaviour it describes lived in a PURR template copy of the draft status bar. The behaviour is generic and belongs in core: - The status bar listed the Review tab only while on it, so a submitter who filled in every section had no visible way to the submit button and stalled. Drop that guard. The Review page itself still offers the button only once curation reports the draft complete, and the submit task re-checks, so an early visit cannot submit an incomplete draft. - Under the status bar, a draft that has not been submitted says so and how to finish, with a separate string for a draft a curator sent back (whose button reads "Re-submit draft to be published"), and nothing on the Review step where the button is. Generic wording in core; a hub that calls its publications something else overrides the two strings. - The string the earlier commit put in the Errors section, with unescaped quotes and PURR wording, is replaced by the two above in the draft-flow section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #1930 (ticket 2812), carrying its commit and adding the rework on top.
Why. #1930 added a language string to core while the behaviour it describes lived in a PURR template copy of
draft/statusbar.php(tpl_doibranchkuang_local_branch_doi_template_09252026). That copy differs from core in exactly two ways, both generic: it drops the guard that hides the Review tab until you are on it, and it shows a "not submitted yet" notice. Those belong in core, where every hub gets them and the copy stops drifting.What this does
.warningstyle). PURR's red styling is ontpl_doibranchpub-review-notice.Verified by rendering the status bar with a stub publication: draft and returned drafts list Content and Review and show the matching notice; on the Review step no notice. Lint clean; the language file parses with the escaped quotes.
🤖 Generated with Claude Code