Skip to content

Publications draft: always list the Review tab, and say how to finish (supersedes #1930) #1940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nkissebe merged 2 commits into from
Oct 7, 2026
Merged

Publications draft: always list the Review tab, and say how to finish (supersedes #1930) #1940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23158e2
[PURR][#2812]Display the Review tab and progress notice to user in pu…
kuang5 Sep 25, 2026
98a484c
Publications draft: always list the Review tab, and say how to finish
nkissebe Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions core/plugins/projects/publications/assets/css/publications.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1959,3 +1959,9 @@
min-width: 800px;
}
}

/* Draft progress notice under the status bar */
.progress-notice {
clear: both;
margin: 0.5em 0 1em 0;
}
2 changes: 2 additions & 0 deletions core/plugins/projects/publications/language/en-GB/en-GB.plg_projects_publications.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1041,6 +1041,8 @@ COM_PUBLICATIONS_ERROR_DOI_NO_SERVICE="The DOI service is either unavailable or
PLG_PROJECTS_PUBLICATIONS_PROJECT_MANAGER="Project manager"
PLG_PROJECTS_PUBLICATIONS_PROJECT_MEMBER="Project member"
PLG_PROJECTS_PUBLICATIONS_DRAFT_READY_TO_SUBMIT="OK to submit"
PLG_PROJECTS_PUBLICATIONS_PROGRESS_NOTICE="This publication has not been submitted yet. When every required field is filled in, open the Review tab and click \"Submit draft\"."
PLG_PROJECTS_PUBLICATIONS_PROGRESS_NOTICE_RESUBMIT="This publication has not been re-submitted yet. When the requested changes are made, open the Review tab and click \"Re-submit draft to be published\"."
PLG_PROJECTS_PUBLICATIONS_ERROR_REGISTER_METADATA="Error registering the DOI metadata and issuing DOI."
PLG_PROJECTS_PUBLICATIONS_ERROR_REGISTER_NAME_URL="Error registering the DOI name and dataset URL."
PLG_PROJECTS_PUBLICATIONS_ERROR_UPDATE_DOI="Failed to update DOI."
Expand Down
14 changes: 8 additions & 6 deletions core/plugins/projects/publications/views/draft/tmpl/statusbar.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,15 +69,17 @@
$class = '';
}
$i++;

// Hide review block until in review
if ($blockname == 'review' && ($blockId != $activenum))
{
continue;
}
?>
<li<?php if ($blockId == $activenum) { echo ' class="active"'; } ?>>
<a href="<?php echo Route::url( $this->pub->link('editversion') . '&section=' . $blockname . '&step=' . $blockId . '&move=continue'); ?>" <?php echo $class ? 'class="' . $class . '"' : ''; ?>><?php echo $block->manifest->label; ?></a>
</li>
<?php } ?>
</ul>
<?php
// A draft that has not been submitted, or that a curator sent back, says
// how to finish, everywhere but on the Review step where the button is.
// The Review tab is always listed above; the page itself only offers the
// button once every required field is filled.
if (in_array($this->pub->state, array(\Components\Publications\Models\Publication::STATE_DRAFT, \Components\Publications\Models\Publication::STATE_WORKED)) && $active != 'review') { ?>
<p class="warning progress-notice"><?php echo Lang::txt($this->pub->isWorked() ? 'PLG_PROJECTS_PUBLICATIONS_PROGRESS_NOTICE_RESUBMIT' : 'PLG_PROJECTS_PUBLICATIONS_PROGRESS_NOTICE'); ?></p>
<?php } ?>
Loading