Repository navigation
ci: share the Playwright browsers between runs - #136
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Agustin-Delgado
changed the title
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two reasons why the Playwright browsers were downloaded on every run:
packages/ui/node_modules/playwright/package.json, andhashFilesreturned an empty string for it (pnpm links the package from outside the workspace). The key wasplaywright-Linux-on every run. It now carries the Playwright version thatplaywright --versionreports, and the runner image (ImageOS), so a move to another Ubuntu image does not reuse browsers installed on the old one.main, as inhuman-kit/charts; the cache saved there is visible to every pull request. The concurrency group falls back togithub.ref, becausehead_refis empty on a push.🤖 Generated with Claude Code