Skip to content

ci: share the Playwright browsers between runs #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Agustin-Delgado merged 3 commits into from
Oct 24, 2026
Merged

ci: share the Playwright browsers between runs #136

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3564f4f
ci: key the Playwright cache on the installed version
Agustin-Delgado Oct 24, 2026
08cf920
ci: run on main too, so the caches it saves reach every pull request
Agustin-Delgado Oct 24, 2026
8eaa813
ci: read ImageOS in the step that builds the cache key
Agustin-Delgado Oct 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,13 @@ name: CI
on:
pull_request:
branches: [main]
# Also on main: a cache saved by a pull request is visible only to that pull
# request, and one saved on main is visible to all of them.
push:
branches: [main]

concurrency:
group: ci-${{ github.head_ref }}
group: ci-${{ github.head_ref || github.ref }}
cancel-in-progress: true

jobs:
Expand Down Expand Up @@ -62,12 +66,22 @@ jobs:

- run: pnpm install --frozen-lockfile

# The key is the installed Playwright version. `hashFiles` on the package in
# `node_modules` gave an empty hash (pnpm links it from outside the workspace),
# so the key never changed and the browsers were downloaded on every run.
- name: Read the Playwright version
id: playwright-version
# `ImageOS` is a variable of the runner, not of the `env` context, so it is read here.
run: |
echo "version=$(cd packages/ui && pnpm exec playwright --version | awk '{print $2}')" >> "$GITHUB_OUTPUT"
echo "image=$ImageOS" >> "$GITHUB_OUTPUT"

- name: Cache Playwright browsers
uses: actions/cache@v4
id: playwright-cache
with:
path: ~/.cache/ms-playwright
key: playwright-${{ runner.os }}-${{ hashFiles('packages/ui/node_modules/playwright/package.json') }}
key: playwright-${{ runner.os }}-${{ steps.playwright-version.outputs.image }}-${{ steps.playwright-version.outputs.version }}

- name: Install Playwright Chromium
if: steps.playwright-cache.outputs.cache-hit != 'true'
Expand Down
Loading