Repository navigation
fix(deps): bump ijson-jcs to 03df9ed for RFC 8785 number ties - #261
hyperpolymath wants to merge 1 commit into
Conversation
The pinned ijson-jcs (3a9a4ee) rearranged Rust's float formatting and printed RFC 8785 Appendix B vector 0x43143ff3c1cb0959 as 1424953923781206.3. JCS requires 1424953923781206.2: ECMAScript Number::toString chooses the even digit on a decimal tie. ijson-jcs main now formats with ryu-js, the ECMAScript algorithm, and passes every Appendix B vector. A test in crate::json pins the vector; on the old pin it fails with the .3 output. New transitive dependency: ryu-js 1.0.3 (Apache-2.0 OR BSL-1.0). cargo audit: no new advisories. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PFaqv6iBXrt3W5Akd1Fq5k
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 20 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Closes the "ijson-jcs tie case" follow-up from #237/#247.
Problem
The pinned
ijson-jcs(3a9a4ee) built ECMAScript number output by rearranging Rust's float formatting. Rust doesn't guarantee ECMAScript's choice on a decimal tie, so RFC 8785 Appendix B vector0x43143ff3c1cb0959came out as1424953923781206.3. JCS requires1424953923781206.2. A report or attestation holding such a float would hash differently from other JCS implementations.Fix
Bump to ijson-jcs
main(03df9ed). It now formats numbers withryu-js, which implements ECMAScriptNumber::toString, and passes every Appendix B vector (cargo test --test rfc8785in ijson-jcs: 5/5). The fix was already upstream, so only the pin needed to move. The lockfile was updated withcargo update -p ijson-jcs.Validation
json::tests::numbers_follow_rfc_8785_on_decimal_tiespins the vector. It fails on the old pin withleft: "1424953923781206.3\n"and passes on the new one.cargo fmt --check, pluscargo clippy --locked --all-targets -D warningswith and without--all-features: clean.cargo test --locked --all-features: all suites green (lib: 524 passed).cargo audit: no new advisories; only the four known upstreamunmaintainedwarnings remain, tracked as W1/W2 in standards' upstream-dependency watch.ryu-js1.0.3, licensedApache-2.0 OR BSL-1.0, which is compatible with MPL-2.0.Existing golden fixtures are unchanged: none of them hold a tie-case float.
Generated by Claude Code