Repository navigation
Report withheld run_python files as received; ask for local chart labels - #271
Merged
Merged
Conversation
A SAFE virtual dialog told the model only "The script finished." after a withheld delivery, so Gemma kept writing send_files=[...] into its reply as if it still had to send the chart. The withheld files now read as received, like the other SAFE tools that fake delivery, so test dialogs continue the way a real chat does. Gemma also kept English chart labels for Russian requests although the tool description asked otherwise; the run_python line of the system prompt now asks for titles and labels in the user's language.
Owner
Author
|
Danger prompt warning: intentional. The change adds one sentence to the existing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After #270, the production SAFE virtual dialog ran the chart script, and
send_withheldlistedsales_chart.png, so auto-delivery works. Two problems remained:send_files=["sales_chart.png"], as if it still had to send the chart. In a real chat the message says the chat received the file. SAFE mode therefore did not reproduce real behavior, unlike the other SAFE tools, which fake a successful delivery (draw_apireturnsdelivered: true).codedescription asks for the user's language.Change
send_withheldstill names the files for operators.prompts/aifarm/system.prompt: the existingrun_pythonsentence gains one instruction: "Заголовки, подписи и текст на графиках пиши на языке собеседника." Partials, role markers and template variables are unchanged.Verification
cargo fmt --all --checkcargo clippy --workspace --all-targets -- -D warningscargo test -p openplotva-app(1434 passed),-p openplotva-prompts(9),-p openplotva-llm(218)After the deploy, the production SAFE virtual dialog will repeat the chart request and a follow-up edit.
Deployment risk
The prompt edit rebuilds the cached system prefix once. Rollback: revert this commit.