Skip to content

fix(builder): correct PR template test command, alerts, branch scopes - #106

Merged
iap merged 3 commits into
mainfrom
fix/pr-template-commands-alerts
Sep 12, 2026
Merged

iap merged 3 commits into
mainfrom
fix/pr-template-commands-alerts

Conversation

@iap

@iap iap commented Sep 12, 2026

Copy link
Copy Markdown
Owner

Summary

Three defects in .github/pull_request_template.md, each verified against repo reality:

  • Test command skipped 21 tests. python -m pytest -q -k "not adapter" deselects everything matching adapter, including test_adapter_sse_parses_via_openai_sdk (the SSE wire-contract guard). Measured: 242 collected full suite vs 221 with the filter. Replaced with the canonical python3 -m pytest tests/ -q (integration tests self-skip without hermes-agent).
  • Alert markers could not render. Bare [!IMPORTANT] / [!WARNING] render as literal text per GitHub docs; converted to the blockquote alert form.
  • Branch prefixes contradicted AGENTS.md scopes. bugs/ and feature/ are not Conventional Commits-lite scopes and feat/ was missing; aligned to feat/fix/sec/refactor/test/docs/chore.

Branch

Opened from fix/pr-template-commands-alerts (matches the corrected scope list).

Note

Markdown-only change; no code, no behavior, no secrets touched.

Checklist

  • Tests pass: python3 -m pytest tests/ -q (241 passed, 1 skipped — suite untouched by this change)
  • verify.py is green
  • No raw tokens/secrets in code, logs, or tool output
  • Adapter stays loopback-only unless an explicit guard is added
  • Updated docs/README if user-facing behavior changed (N/A — template only)

RetriggerConfidence Score: 5/5

Safe to merge.

Fix All in CursorFindings

  1. P2 Feature Labels Are Skipped

Summary

  • This update aligns pull-request guidance with automatic labeling by documenting supported branch prefixes and mapping feat/ and docs/ branches to their corresponding labels.

Reviews (4) · Last reviewed commit: "docs: template references Conventional C..."

@github-actions github-actions Bot added the bug Something isn't working label Sep 12, 2026
This PR was opened from a branch using one of:
This PR was opened from a branch using one of (matching a Conventional
Commits-lite scope in `AGENTS.md`):
- `feat/…`

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Feature Labels Are Skipped

The template directs contributors to use feat/…, but the branch-label workflow only maps feature/ to the enhancement label. Pull requests opened from the documented prefix therefore receive no feature label, leaving them incorrectly categorized for triage. This is a non-blocking concern, but the template and workflow should use the same prefix set.

Artifacts

Evidence from the check

  • A Node.js harness was authored to parse the workflow label map and exercise its exact prefix-matching behavior for documented and workflow-only branch prefixes; it provides the reproducible check.

Command output from the check

  • The executed harness completed with exit code 0 and shows `feat/deterministic-check` matched no prefix, invoked no label action, and received no enhancement label; the documented path is broken.

View artifacts

T-Rex Ran code and verified through T-Rex

Fix in Cursor

iap added 3 commits September 12, 2026 20:57
- Test command ran 'python -m pytest -q -k "not adapter"', silently
  skipping 21 adapter tests including the SSE wire-contract test; use the
  canonical 'python3 -m pytest tests/ -q' (integration tests self-skip
  without hermes-agent).
- Bare [!IMPORTANT]/[!WARNING] markers render as literal text; use the
  blockquote alert form so GitHub renders the callouts.
- Branch prefixes contradicted the AGENTS.md scopes (bugs/, feature/
  are not scopes; feat/ was missing); align to feat/fix/sec/refactor/
  test/docs/chore.
The PR template documents feat/ branches, but the auto-label workflow
only knew fix/bugs/feature — feat/ PRs got no label. Add feat/ (plus
docs/ -> documentation); keep feature/ and bugs/ as tolerated aliases.
All target labels exist, so addLabels cannot 422.
@iap
iap force-pushed the fix/pr-template-commands-alerts branch from 49754af to 0650336 Compare September 12, 2026 13:58
@iap
iap merged commit 6377e77 into main Sep 12, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant