fix(builder): correct PR template test command, alerts, branch scopes - #106
Merged
Merged
Conversation
| This PR was opened from a branch using one of: | ||
| This PR was opened from a branch using one of (matching a Conventional | ||
| Commits-lite scope in `AGENTS.md`): | ||
| - `feat/…` |
There was a problem hiding this comment.
The template directs contributors to use feat/…, but the branch-label workflow only maps feature/ to the enhancement label. Pull requests opened from the documented prefix therefore receive no feature label, leaving them incorrectly categorized for triage. This is a non-blocking concern, but the template and workflow should use the same prefix set.
Artifacts
- A Node.js harness was authored to parse the workflow label map and exercise its exact prefix-matching behavior for documented and workflow-only branch prefixes; it provides the reproducible check.
- The executed harness completed with exit code 0 and shows `feat/deterministic-check` matched no prefix, invoked no label action, and received no enhancement label; the documented path is broken.
- Test command ran 'python -m pytest -q -k "not adapter"', silently skipping 21 adapter tests including the SSE wire-contract test; use the canonical 'python3 -m pytest tests/ -q' (integration tests self-skip without hermes-agent). - Bare [!IMPORTANT]/[!WARNING] markers render as literal text; use the blockquote alert form so GitHub renders the callouts. - Branch prefixes contradicted the AGENTS.md scopes (bugs/, feature/ are not scopes; feat/ was missing); align to feat/fix/sec/refactor/ test/docs/chore.
The PR template documents feat/ branches, but the auto-label workflow only knew fix/bugs/feature — feat/ PRs got no label. Add feat/ (plus docs/ -> documentation); keep feature/ and bugs/ as tolerated aliases. All target labels exist, so addLabels cannot 422.
iap
force-pushed
the
fix/pr-template-commands-alerts
branch
from
September 12, 2026 13:58
49754af to
0650336
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three defects in
.github/pull_request_template.md, each verified against repo reality:python -m pytest -q -k "not adapter"deselects everything matchingadapter, includingtest_adapter_sse_parses_via_openai_sdk(the SSE wire-contract guard). Measured: 242 collected full suite vs 221 with the filter. Replaced with the canonicalpython3 -m pytest tests/ -q(integration tests self-skip without hermes-agent).[!IMPORTANT]/[!WARNING]render as literal text per GitHub docs; converted to the blockquote alert form.bugs/andfeature/are not Conventional Commits-lite scopes andfeat/was missing; aligned tofeat/fix/sec/refactor/test/docs/chore.Branch
Opened from
fix/pr-template-commands-alerts(matches the corrected scope list).Note
Markdown-only change; no code, no behavior, no secrets touched.
Checklist
python3 -m pytest tests/ -q(241 passed, 1 skipped — suite untouched by this change)verify.pyis greenSafe to merge.
Summary
feat/anddocs/branches to their corresponding labels.Reviews (4) · Last reviewed commit: "docs: template references Conventional C..."