Skip to content

fix(builder): correct PR template test command, alerts, branch scopes #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iap merged 3 commits into from
Sep 12, 2026
Merged

fix(builder): correct PR template test command, alerts, branch scopes #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b9b4a4
fix(builder): correct PR template test command, alerts, branch scopes
iap Sep 12, 2026
4ec5f97
fix(builder): map feat/ and docs/ branch prefixes to labels
iap Sep 12, 2026
0650336
docs: template references Conventional Commits types, not scopes
iap Sep 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,24 +14,26 @@ Briefly describe the change and why it is needed.

## Branch

This PR was opened from a branch using one of:
This PR was opened from a branch using one of (matching a Conventional
Commits type in `AGENTS.md`):
- `feat/…`

@greptile-apps greptile-apps Bot Sep 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Feature Labels Are Skipped

The template directs contributors to use feat/…, but the branch-label workflow only maps feature/ to the enhancement label. Pull requests opened from the documented prefix therefore receive no feature label, leaving them incorrectly categorized for triage. This is a non-blocking concern, but the template and workflow should use the same prefix set.

Artifacts

Evidence from the check

  • A Node.js harness was authored to parse the workflow label map and exercise its exact prefix-matching behavior for documented and workflow-only branch prefixes; it provides the reproducible check.

Command output from the check

  • The executed harness completed with exit code 0 and shows `feat/deterministic-check` matched no prefix, invoked no label action, and received no enhancement label; the documented path is broken.

View artifacts

T-Rex Ran code and verified through T-Rex

Fix in Cursor

- `fix/…`
- `bugs/…`
- `feature/…`
- `chore/…`
- `docs/…`
- `test/…`
- `refactor/…`
- `sec/…`
- `refactor/…`
- `test/…`
- `docs/…`
- `chore/…`

[!IMPORTANT] Branch must use the Conventional Commits-lite prefix matching the PR scope.
> [!IMPORTANT]
> Branch prefix must match the PR's scope.

## Checklist

- [ ] Tests pass: `python -m pytest -q -k "not adapter"`
- [ ] Tests pass: `python3 -m pytest tests/ -q`
- [ ] `verify.py` is green
- [ ] No raw tokens/secrets in code, logs, or tool output
- [ ] Adapter stays loopback-only unless an explicit guard is added
- [ ] Updated docs/README if user-facing behavior changed

[!WARNING] Do NOT merge if `verify.py` reports a secret leak. This is a hard gate.
> [!WARNING]
> Do NOT merge if `verify.py` reports a secret leak. This is a hard gate.
4 changes: 3 additions & 1 deletion .github/workflows/pr-label.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ jobs:
const labels = {
'fix/': 'bug',
'bugs/': 'bug',
'feature/': 'enhancement'
'feat/': 'enhancement',
'feature/': 'enhancement',
'docs/': 'documentation'
}
const mapping = Object.entries(labels).find(([prefix]) => branch.startsWith(prefix))
if (!mapping) return
Expand Down
Loading