[xabg2]

Description

• Uploading from the Drive explorer (upload button, folder picker and dropping onto the explorer) now goes through the new upload flow.
• Every check runs once, before anything is uploaded: the item limit, files over the size limit (listed together in one dialog, while the rest is uploaded), hidden files inside folders (left out), the storage left (plan limit dialog, nothing uploaded) and names that already exist (name collision dialog, only the rest is uploaded).
• Each uploaded folder has one task whose progress follows its content, and each loose file has its own task. Failed items can be retried from the task.
• Cancelling a folder upload removes the folder already created. Filling the storage while uploading shows the plan limit dialog once.
• Works the same inside a workspace. Dropping onto a folder in the list or a breadcrumb, and shared folders, move onto this flow in the next PRs.

Related Issues

N/A

Related Pull Requests

Depends on: list the failed items of an upload task in the retry dialog (#2267).

Checklist

• Changes have been tested locally.
• Unit tests have been written or updated as necessary.
• The code adheres to the repository's coding standards.
• Relevant documentation has been added or updated.
• No new warnings or errors have been introduced.
• SonarCloud issues have been reviewed and addressed.
• QA Passed

Testing Process

Unit tests for uploading from the explorer pickers and by dropping, and for the upload entry running the real upload with only the network faked: name collisions, the item limit, files over the size limit, hidden files, not enough storage, workspaces, the items listed as they upload and the storage filling up. Typecheck, lint and the upload, tasks, store, drive, views and components tests pass.

Additional Notes

Most of the size is moved code and tests: the old explorer upload helpers are removed and their logic now lives in the upload module.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 59fcf34f-6076-4033-916b-bf881734f1e3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[cloudflare-workers-and-pages]

Deploying drive-web with    Cloudflare Pages

Latest commit:	084b8ba
Status:	✅  Deploy successful!
Preview URL:	https://c0c1c2d5.drive-web.pages.dev
Branch Preview URL:	https://refactor-upload-explorer-ent.drive-web.pages.dev

View logs

[sonarqubecloud]

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE