[xabg2]

Description

• Dropping files and folders onto a folder in the list, or onto a breadcrumb (Drive, Backups, Shared and the move dialog), now goes through the new upload flow, with the same checks as uploading from the explorer: item limit, size limit, storage left and names that already exist.
• The choices of the name collision dialog upload through the new flow too:
  • Keep both gives a free name to folders as well as files, and uploads them together in one upload.
  • Replace sends the existing items to the trash and uploads the new ones; files that support versions still become a new version.
  • Skip merges the new content of a folder into the existing one, uploading its new files and subfolders together.

Related Issues

N/A

Related Pull Requests

Depends on: upload from the Drive explorer through the new upload flow (#2269).

Checklist

• Changes have been tested locally.
• Unit tests have been written or updated as necessary.
• The code adheres to the repository's coding standards.
• Relevant documentation has been added or updated.
• No new warnings or errors have been introduced.
• SonarCloud issues have been reviewed and addressed.
• QA Passed

Testing Process

Unit tests for dropping files onto a breadcrumb (uploaded into that folder, and the error shown when the dropped items cannot be read) and for every choice of the name collision dialog when uploading (keep both, replace with and without versions, skip and merge). Typecheck, lint and the upload, tasks, store, drive, views and components tests pass.

Additional Notes

N/A

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 6ec264b5-43b2-472c-91a4-40624e86fb65

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[cloudflare-workers-and-pages]

Deploying drive-web with    Cloudflare Pages

Latest commit:	ef91de4
Status:	✅  Deploy successful!
Preview URL:	https://a972254c.drive-web.pages.dev
Branch Preview URL:	https://refactor-upload-other-entrie.drive-web.pages.dev

View logs

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud