[xabg2]

Description

• Uploading files into a shared folder, or into one of its subfolders, now goes through the new upload flow, as owner and as editor, also inside a workspace.
• Files are uploaded with the folder owner's credentials, as before. If the owner's storage is full, the owner storage dialog is shown.
• A file whose name already exists in the shared folder is uploaded under the next free name, such as "report (1).pdf". Empty files are skipped, as before.
• Failed files can be retried from their task. If the files cannot be prepared for upload (for example, the shared folder cannot be listed), an upload error is shown.

Related Issues

N/A

Related Pull Requests

Depends on: upload by dropping on folders and breadcrumbs, and from the name collision dialog, through the new upload flow (#2270).

Checklist

• Changes have been tested locally.
• Unit tests have been written or updated as necessary.
• The code adheres to the repository's coding standards.
• Relevant documentation has been added or updated.
• No new warnings or errors have been introduced.
• SonarCloud issues have been reviewed and addressed.
• QA Passed

Testing Process

Unit tests for the free names in a shared folder: a taken name, a free name, several files with the same name, a folder with more than one page of files and a workspace shared folder. Typecheck, lint and the upload, tasks, store, drive, views and components tests pass.

Additional Notes

N/A

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 803c089c-6e08-46ab-9741-4aeebec351b3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[cloudflare-workers-and-pages]

Deploying drive-web with    Cloudflare Pages

Latest commit:	7aa1abf
Status:	✅  Deploy successful!
Preview URL:	https://83f18d18.drive-web.pages.dev
Branch Preview URL:	https://refactor-upload-shared-view.drive-web.pages.dev

View logs

[sonarqubecloud]

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE