Repository navigation
Write the native state produced by VMEC conversion - #18
Merged
Merged
Conversation
krystophny
force-pushed
the
fix/convert-wout-state-20261024
branch
from
October 23, 2026 23:19
707495d to
50895d4
Compare
krystophny
changed the base branch from
develop
to
fix/init-default-proposals-20261024
October 23, 2026 23:19
krystophny
force-pushed
the
fix/convert-wout-state-20261024
branch
from
October 23, 2026 23:30
50895d4 to
6a39eb0
Compare
krystophny
changed the base branch from
fix/init-default-proposals-20261024
to
develop
October 23, 2026 23:30
krystophny
marked this pull request as ready for review
October 23, 2026 23:30
krystophny
enabled auto-merge
October 23, 2026 23:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GVEC VMEC converter assumes initialization creates a native state file, while the binding suppresses output. An actual published Landreman–Paul QA conversion therefore raises IndexError before chartmap generation for SIMPLE.
Save the initialized native state with the existing writer before copying it. Four existing synthetic positive/negative-Jacobian and symmetric/asymmetric VMEC inputs now convert and reload, and their boundary points match the original VMEC Fourier coefficients. No native evolution, new binary or private fixture is introduced.
Slurm3362324 qualified integrated50895d4a: original default1 and converter4 cases fail before their respective repairs, repaired5/5 pass, full1314Python tests pass (31existing skips,36expected failures), and all17native tests pass in clean resident generation18b62645be5677bdf71c9f125cfe1ce97634b98d1bfa84255bd5bb2f1f7cd95a. Private Fo/runtime pre/post identities match and owner exit is verified. Final canonicalcae1ac53 has the identical qualified tree4c1356a2afad489bd14fa99f13ba2a98eff6d97e.
Original head50895d4a was restacked with OLDLOWER181f26ed onto squash3aefb809, leaving only this converter repair at6a39eb0a, then squashed ascae1ac53. Both heads have verified archive tags. Standalone genuine upstream repair remains draft MR196. Later native-only optional import collection is tracked separately in #20, preserving the failed CI receipt.
Chris&AI