Repository navigation
fix(format): ignore inherited extended parameters - #149
Closed
awais-ur-rehman wants to merge 1 commit into
Closed
awais-ur-rehman wants to merge 1 commit into
awais-ur-rehman wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #149 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 213 215 +2
Branches 58 60 +2
=========================================
+ Hits 213 215 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
This opens a can of worms because it doesn't completely work, opting to revert hiding keys in #151 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An inherited
filename*property currently suppresses an own Unicodefilename, even though the formatter emits only own properties. Check that the extended parameter is an own property before using it to suppress another parameter, so the filename stays in the header.Breaking Changes
None.
Testing
filename*and an own Unicodefilename; it fails before the fix.npm test— 201 tests pass, including TypeScript and formatting checks; 100% statements/functions/lines and 98.37% branches.npm run buildgit diff --checkfilename*, set its ownfilenameto€ rates.pdf, and pass it toformat. Confirm that the header containsfilename*=UTF-8''%E2%82%AC%20rates.pdf.