Skip to content

fix(format): ignore inherited extended parameters - #149

Closed
awais-ur-rehman wants to merge 1 commit into
jshttp:masterfrom
awais-ur-rehman:feat/own-extended-parameters
Closed

awais-ur-rehman wants to merge 1 commit into
jshttp:masterfrom
awais-ur-rehman:feat/own-extended-parameters

Conversation

@awais-ur-rehman

Copy link
Copy Markdown

Summary

An inherited filename* property currently suppresses an own Unicode filename, even though the formatter emits only own properties. Check that the extended parameter is an own property before using it to suppress another parameter, so the filename stays in the header.

Breaking Changes

None.

Testing

  • Added a regression test with an inherited filename* and an own Unicode filename; it fails before the fix.
  • npm test — 201 tests pass, including TypeScript and formatting checks; 100% statements/functions/lines and 98.37% branches.
  • npm run build
  • git diff --check
  • To check manually, create a parameters object with an inherited filename*, set its own filename to € rates.pdf, and pass it to format. Confirm that the header contains filename*=UTF-8''%E2%82%AC%20rates.pdf.

@codecov

codecov Bot commented Nov 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (1a542fe) to head (9a0f7aa).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #149   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          213       215    +2     
  Branches        58        60    +2     
=========================================
+ Hits           213       215    +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blakeembrey

Copy link
Copy Markdown
Member

This opens a can of worms because it doesn't completely work, opting to revert hiding keys in #151 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants