Skip to content

fix: decode the power limit Smart Grid mode and the restart timer in seconds - #85

Merged
kristoflemmens merged 3 commits into
mainfrom
fix/power-limit-findings
Nov 19, 2026
Merged

kristoflemmens merged 3 commits into
mainfrom
fix/power-limit-findings

Conversation

@kristoflemmens

Copy link
Copy Markdown
Contributor

From the power limit test on the reference pump (PL/LU mode, firmware 18.0.1), klconsultancy/ha-thermia-genesis#45:

  • Input 82 smart_grid_mode reads 10 while holding 124 applies the power limit; the display shows "Huidige modus: Vermogensbegrenzing". Footnote *4 doesn't list it, so it decoded as None. New member SmartGridMode.POWER_LIMIT = 10.
  • Input 60 compressor_start_restriction_timer counts the compressor restart down in seconds (123, then 22 101 s later, while the display counted down 5 minutes). It now has unit="s", recorded as a unit erratum.
  • Errata for holding 124 and 125: where the mode is set on the display, what writing them did, that 125 reads 0.0 kW out of the box and is volatile (reset by a power cycle).

The Load-Up value of input 82 is still unknown (not tested).

🤖 Generated with Claude Code

…seconds

Measured on the reference pump in PL/LU mode (firmware 18.0.1): input 82
reads 10 while holding 124 applies the power limit, and input 60 counts the
compressor restart down in seconds. Record both, and what the power limit
test showed for holding 124 and 125, in the errata.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Comment thread src/thermia_genesis/v17_1/enums.py Resolved
Comment thread docs/errata.md Resolved
@claude

claude Bot commented Nov 18, 2026

Copy link
Copy Markdown

Scope full (first review): 5 files read, 2 findings; rules: AGENTS.md, CLAUDE.md, CONTEXT.md, docs/design.md, docs/errata.md

What this review covered

Files read in full: docs/errata.md (PR version), src/thermia_genesis/v17_1/enums.py, src/thermia_genesis/v17_1/heat_pump_unit.py, tests/test_v17_1_decoding.py, tests/test_v17_1_register_map.py.

Files skipped: none.

Rules that applied:

  • AGENTS.md, strict TDD and coverage: each production change has a test. SmartGridMode.POWER_LIMIT is covered by test_reads_the_power_limit_smart_grid_mode. The unit="s" on input 60 is required by the new UNIT_ERRATA entry and test_field_has_the_documented_unit. I did not run the tests or the coverage gate.
  • AGENTS.md, Registers: each departure from chapter 3 (the unit of input 60, value 10 on input 82) has a row in docs/errata.md, with its evidence.
  • AGENTS.md, update docs/design.md / CONTEXT.md when a design choice or domain term changes: not met. See the two inline findings: the CONTEXT.md definition of "Smart grid mode", and the reference pump firmware (18.0.1) against design.md.
  • docs/design.md, Register map: units and enum values follow chapter 3 unless the errata record otherwise; the consistency test lists the unit erratum.
  • docs/design.md, Encoding: input 60 stays an unsigned integer.

Rules files this PR changes (judged by the base version): docs/errata.md.

Findings that could not be posted inline: none.

… the findings

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@claude

claude Bot commented Nov 18, 2026

Copy link
Copy Markdown

Scope bcda3d3..a450fca: 3 files read, 0 findings; rules: AGENTS.md (via CLAUDE.md), CONTEXT.md, docs/design.md, docs/errata.md

What this review covered
  • Files read (PR versions from the review bundle's head-rules copies, plus the full diff): CONTEXT.md, docs/design.md, docs/errata.md. Also checked src/thermia_genesis/v17_1/enums.py and heat_pump_unit.py to confirm that SmartGridMode.POWER_LIMIT = 10 exists and is decoded from input 82, as the new text says.
  • Files skipped: none.
  • Rules that applied:
    • AGENTS.md: update docs/design.md / CONTEXT.md in the same PR when a domain term changes. The Smart grid mode definition in CONTEXT.md now covers power limit, and design.md now says that enum values can come from the errata as well as the footnotes. This matches the code.
    • AGENTS.md: record pump behaviour that the documentation does not describe in docs/errata.md. The firmware version (18.0.1) is now named for the 2026-11-18 observations on holding 125 and input 60.
    • AGENTS.md strict TDD / 100% coverage: not applicable, because this change is documentation only.
  • Rules files this PR changes (judged by their base versions): CONTEXT.md, docs/design.md, docs/errata.md.
  • Findings that could not be posted inline: none.
  • Note, not a finding (outside the changed lines): docs/design.md:14 still gives the reference hardware as firmware 17.1.11, and the "Undocumented behaviour" heading in docs/errata.md still reads "Observed on the reference pump (firmware 17.1.11)". The errata rows now name 18.0.1, so you may want to bring those lines in line too.

@claude

claude Bot commented Nov 19, 2026

Copy link
Copy Markdown

Scope a450fca..7be0321: no new PR changes since the last review (only updates from the base)

@kristoflemmens
kristoflemmens added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit 1fc1917 Nov 19, 2026
14 checks passed
@kristoflemmens
kristoflemmens deleted the fix/power-limit-findings branch November 19, 2026 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant