Repository navigation
fix: decode the power limit Smart Grid mode and the restart timer in seconds - #85
Merged
Merged
Conversation
…seconds Measured on the reference pump in PL/LU mode (firmware 18.0.1): input 82 reads 10 while holding 124 applies the power limit, and input 60 counts the compressor restart down in seconds. Record both, and what the power limit test showed for holding 124 and 125, in the errata. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Scope full (first review): 5 files read, 2 findings; rules: AGENTS.md, CLAUDE.md, CONTEXT.md, docs/design.md, docs/errata.md What this review coveredFiles read in full: Files skipped: none. Rules that applied:
Rules files this PR changes (judged by the base version): Findings that could not be posted inline: none. |
… the findings Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Scope bcda3d3..a450fca: 3 files read, 0 findings; rules: AGENTS.md (via CLAUDE.md), CONTEXT.md, docs/design.md, docs/errata.md What this review covered
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the power limit test on the reference pump (PL/LU mode, firmware 18.0.1), klconsultancy/ha-thermia-genesis#45:
smart_grid_modereads 10 while holding 124 applies the power limit; the display shows "Huidige modus: Vermogensbegrenzing". Footnote *4 doesn't list it, so it decoded asNone. New memberSmartGridMode.POWER_LIMIT = 10.compressor_start_restriction_timercounts the compressor restart down in seconds (123, then 22 101 s later, while the display counted down 5 minutes). It now hasunit="s", recorded as a unit erratum.The Load-Up value of input 82 is still unknown (not tested).
🤖 Generated with Claude Code