Skip to content

feat: support firmware 18.0 - #86

Merged
kristoflemmens merged 1 commit into
mainfrom
feat/firmware-18-0
Nov 18, 2026
Merged

kristoflemmens merged 1 commit into
mainfrom
feat/firmware-18-0

Conversation

@kristoflemmens

Copy link
Copy Markdown
Contributor

Closes #84.

The reference pump updated itself from 17.1.11 to 18.0.1. Its read-only dump matches the 17.1 map address for address: the same 250 addresses, no failed read, no holding register changed, and the input registers that differ follow from the compressor running during the 18.0.1 dump (details in #84).

  • FirmwareVersion.supported accepts 18.0 next to 17.1, so Home Assistant drops the Unsupported heat pump firmware repair on 18.0.
  • The dump becomes the fixture tests/fixtures/calibra7-18.0.1.json, replayed like the 17.1.11 one.
  • Errata (document-wide): 18.0 is checked against a dump only. A register 18.0 adds, or a changed meaning behind an equal value, would not show; no protocol document for 18.0 is available yet.
  • design.md and README name 18.0.

Values decoded in the fixture come from main, before #85; #85 changes no fixture value (input 82 read 4 and input 60 read 0 during the dump).

🤖 Generated with Claude Code

The reference pump updated itself from 17.1.11 to 18.0.1. Its dump matches
the 17.1 map address for address, so 18.0 uses that map and no longer
reports as unsupported. Add the dump as a fixture.

Closes #84

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@claude

claude Bot commented Nov 18, 2026

Copy link
Copy Markdown

Scope full (first review): 6 files read, 0 findings; rules: AGENTS.md, CLAUDE.md, CONTEXT.md, docs/design.md, docs/errata.md

What this review covered
  • Files read: README.md, docs/design.md (PR version from the head-rules copy), docs/errata.md (PR version from the head-rules copy), src/thermia_genesis/firmware.py, tests/fixtures/calibra7-18.0.1.json (through the diff, as a new file), tests/test_firmware.py. For context I also read tests/test_fixtures.py and the holding section of tests/fixtures/calibra7-17.1.11.json.
  • Files skipped: none.
  • Rules that applied:
    • AGENTS.md, strict TDD and 100% coverage: test_reports_firmware_18_0_as_supported covers the new SUPPORTED membership. The unsupported-version test moves from 18.0.2 to 19.0.2, so the False branch is still covered. The new fixture is replayed by the parametrized test_replays_the_fixture, which globs tests/fixtures/*.json.
    • AGENTS.md, update docs/design.md and CONTEXT.md when a design choice changes: the Scope and Firmware sections of docs/design.md are updated. CONTEXT.md needs no change.
    • AGENTS.md / docs/errata.md, record pump behaviour the documentation does not describe: the Document-wide table gets a Firmware 18.0 row. I checked its claim of no change in any holding register: the holding registers in the 18.0.1 fixture match the 17.1.11 fixture value for value.
    • AGENTS.md, never write to a real pump from tests: the tests use only the mock unit.
    • AGENTS.md, Conventional Commits title: feat: support firmware 18.0 follows it.
  • Rules files this PR changes (judged by their base versions): docs/design.md, docs/errata.md.
  • Findings that could not be posted inline: none.

@kristoflemmens
kristoflemmens added this pull request to the merge queue Nov 18, 2026
Merged via the queue into main with commit cb6aacc Nov 18, 2026
14 checks passed
@kristoflemmens
kristoflemmens deleted the feat/firmware-18-0 branch November 18, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support firmware 18.0

1 participant