Repository navigation
feat: support firmware 18.0 - #86
Merged
Merged
Conversation
The reference pump updated itself from 17.1.11 to 18.0.1. Its dump matches the 17.1 map address for address, so 18.0 uses that map and no longer reports as unsupported. Add the dump as a fixture. Closes #84 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Scope full (first review): 6 files read, 0 findings; rules: AGENTS.md, CLAUDE.md, CONTEXT.md, docs/design.md, docs/errata.md What this review covered
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #84.
The reference pump updated itself from 17.1.11 to 18.0.1. Its read-only dump matches the 17.1 map address for address: the same 250 addresses, no failed read, no holding register changed, and the input registers that differ follow from the compressor running during the 18.0.1 dump (details in #84).
FirmwareVersion.supportedaccepts 18.0 next to 17.1, so Home Assistant drops the Unsupported heat pump firmware repair on 18.0.tests/fixtures/calibra7-18.0.1.json, replayed like the 17.1.11 one.Values decoded in the fixture come from
main, before #85; #85 changes no fixture value (input 82 read 4 and input 60 read 0 during the dump).🤖 Generated with Claude Code