Skip to content

Upgrade neko to 2.4.1 - #148

Open
tobil4sk wants to merge 2 commits into
krdlab:masterfrom
tobil4sk:neko-2.4.1
Open

tobil4sk wants to merge 2 commits into
krdlab:masterfrom
tobil4sk:neko-2.4.1

Conversation

@tobil4sk

Copy link
Copy Markdown
Contributor

No description provided.

@MRK2009 MRK2009 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to change the comments that still says 2.4.0

@tobil4sk

Copy link
Copy Markdown
Contributor Author

It seems to me like the comment is to provide an example of the url format, rather than to state what the actual current version is. The haxe version is also old (4.0.5). I don't think there is much value in making those example urls up-to-date with the current version because it is just one of the possible versions that can end up installed and it can easily become outdated since it is just a comment.

I could replace with 2.4.0 with x.y.z to avoid this issue, but I think for the example of the haxe archive layout it is useful to have a concrete example rather than a generic one:

  // e.g. haxe-4.0.5-linux64.tar.gz -> haxe-4.0.5-linux64/haxe_20191217082701_67feacebc

@MRK2009

MRK2009 commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

I see huh.
Well fair enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants