Skip to content

Upgrade neko to 2.4.1 #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tobil4sk wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Upgrade neko to 2.4.1 #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3043e6b
Upgrade neko to 2.4.1
tobil4sk Jul 16, 2025
d344dd5
Update tests for neko 2.4.1
tobil4sk Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4254,7 +4254,7 @@ class NekoAsset extends Asset {
return new NekoAsset('latest', true, forceArch);
}
// NOTE: Haxe older than 4.3 has known issues with mbedtls 3 in Neko 2.4.
const nekoVer = version.startsWith('3.') || (version.startsWith('4.') && version < '4.3.') ? '2.3.0' : '2.4.0';
const nekoVer = version.startsWith('3.') || (version.startsWith('4.') && version < '4.3.') ? '2.3.0' : '2.4.1';
return new NekoAsset(nekoVer, false, forceArch);
}
constructor(version, nightly, forceArch) {
Expand Down
30 changes: 15 additions & 15 deletions src/asset.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,15 +118,15 @@ describe('HaxeAsset (nightly)', () => {

describe('NekoAsset (stable)', () => {
it.each([
['linux', 'x64', '2.4.0', undefined, 'neko-2.4.0-linux64.tar.gz', 'v2-4-0'],
['linux', 'x64', '2.4.1', undefined, 'neko-2.4.1-linux64.tar.gz', 'v2-4-1'],
['linux', 'x64', '2.3.0', undefined, 'neko-2.3.0-linux64.tar.gz', 'v2-3-0'],
['linux', 'arm64', '2.4.0', undefined, 'neko-2.4.0-linux-arm64.tar.gz', 'v2-4-0'],
['darwin', 'x64', '2.4.0', undefined, 'neko-2.4.0-osx-universal.tar.gz', 'v2-4-0'],
['darwin', 'arm64', '2.4.0', undefined, 'neko-2.4.0-osx-universal.tar.gz', 'v2-4-0'],
['linux', 'arm64', '2.4.1', undefined, 'neko-2.4.1-linux-arm64.tar.gz', 'v2-4-1'],
['darwin', 'x64', '2.4.1', undefined, 'neko-2.4.1-osx-universal.tar.gz', 'v2-4-1'],
['darwin', 'arm64', '2.4.1', undefined, 'neko-2.4.1-osx-universal.tar.gz', 'v2-4-1'],
['darwin', 'x64', '2.3.0', undefined, 'neko-2.3.0-osx64.tar.gz', 'v2-3-0'],
['win32', 'x64', '2.4.0', undefined, 'neko-2.4.0-win64.zip', 'v2-4-0'],
['win32', 'x64', '2.4.1', undefined, 'neko-2.4.1-win64.zip', 'v2-4-1'],
['win32', 'x64', '2.3.0', 'ia32', 'neko-2.3.0-win.zip', 'v2-3-0'],
['win32', 'arm64', '2.4.0', 'x64', 'neko-2.4.0-win64.zip', 'v2-4-0'],
['win32', 'arm64', '2.4.1', 'x64', 'neko-2.4.1-win64.zip', 'v2-4-1'],
['win32', 'arm64', '2.3.0', 'ia32', 'neko-2.3.0-win.zip', 'v2-3-0'],
] as const)('%s/%s + Neko %s (forceArch=%s)', (platform, arch, version, forceArch, fileName, tag) => {
setOs(platform, arch);
Expand Down Expand Up @@ -176,9 +176,9 @@ describe('NekoAsset.resolveFromHaxeVersion', () => {
['3.4.7', false, '2.3.0'],
['4.0.5', false, '2.3.0'],
['4.2.5', false, '2.3.0'],
['4.3.0', false, '2.4.0'],
['4.3.7', false, '2.4.0'],
['5.0.0-preview.1', false, '2.4.0'],
['4.3.0', false, '2.4.1'],
['4.3.7', false, '2.4.1'],
['5.0.0-preview.1', false, '2.4.1'],
['latest', true, 'latest'],
['2026-03-19_master_5f449dc', true, 'latest'],
] as const)('Haxe %s (nightly=%s) -> Neko %s', (haxeVer, nightly, expectedNeko) => {
Expand Down Expand Up @@ -225,11 +225,11 @@ describe('NekoAsset.resolveFromHaxeVersion', () => {
expect(() => (neko as unknown as { downloadUrl: string }).downloadUrl).toThrow(/Neko 2\.3\.x has no Linux ARM64/);
});

it('Linux ARM64 + Haxe 4.3.0 (Neko 2.4.0) -> linux-arm64 archive', () => {
it('Linux ARM64 + Haxe 4.3.0 (Neko 2.4.1) -> linux-arm64 archive', () => {
setOs('linux', 'arm64');
const neko = NekoAsset.resolveFromHaxeVersion('4.3.0', false);
expect(neko.version).toBe('2.4.0');
expect((neko as unknown as { fileNameWithoutExt: string }).fileNameWithoutExt).toBe('neko-2.4.0-linux-arm64');
expect(neko.version).toBe('2.4.1');
expect((neko as unknown as { fileNameWithoutExt: string }).fileNameWithoutExt).toBe('neko-2.4.1-linux-arm64');
});
});

Expand All @@ -243,9 +243,9 @@ describe('resolveTarget cachePlatform (haxelib cache key compatibility)', () =>
['haxe', 'latest', 'linux', 'x64', true, 'linux64'],
['haxe', 'latest', 'darwin', 'arm64', true, 'osx'],
['haxe', 'latest', 'linux', 'arm64', true, 'linux-arm64'],
['neko', '2.4.0', 'linux', 'x64', false, 'linux64'],
['neko', '2.4.0', 'darwin', 'arm64', false, 'osx'],
['neko', '2.4.0', 'linux', 'arm64', false, 'linux-arm64'],
['neko', '2.4.1', 'linux', 'x64', false, 'linux64'],
['neko', '2.4.1', 'darwin', 'arm64', false, 'osx'],
['neko', '2.4.1', 'linux', 'arm64', false, 'linux-arm64'],
] as const)('%s %s on %s/%s (nightly=%s) -> cachePlatform=%s', (tool, version, platform, arch, nightly, expectedCachePlatform) => {
const result = resolveTarget({
tool,
Expand Down
2 changes: 1 addition & 1 deletion src/asset.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ export class NekoAsset extends Asset {
}

// NOTE: Haxe older than 4.3 has known issues with mbedtls 3 in Neko 2.4.
const nekoVer = version.startsWith('3.') || (version.startsWith('4.') && version < '4.3.') ? '2.3.0' : '2.4.0';
const nekoVer = version.startsWith('3.') || (version.startsWith('4.') && version < '4.3.') ? '2.3.0' : '2.4.1';

return new NekoAsset(nekoVer, false, forceArch);
}
Expand Down