feat(blog): remember the chosen post language across visits - #42
Merged
Conversation
The blog index toggles between English and German panels client-side but reset to English on every visit, so a German reader re-selected the language on every arrival. The theme already persists; the language now does too. - Store the choice under `blogLang` on click and restore it on init - Only restore a language that still has a panel, so a stored value that outlives its posts cannot hide every panel and leave an empty page - Guard reads and writes: localStorage throws rather than returning null when a browser blocks storage, and a toggle that stops working is worse than one that forgets
leinss
added a commit
that referenced
this pull request
Aug 19, 2026
The blog index toggles between English and German panels client-side but reset to English on every visit, so a German reader re-selected the language on every arrival. The theme already persists; the language now does too. - Store the choice under `blogLang` on click and restore it on init - Only restore a language that still has a panel, so a stored value that outlives its posts cannot hide every panel and leave an empty page - Guard reads and writes: localStorage throws rather than returning null when a browser blocks storage, and a toggle that stops working is worse than one that forgets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The blog index toggles between English and German panels client-side, but reset
to English on every arrival, so a German reader re-selected the language every
visit. The theme already persisted; the language now does too.
blogLangon click and restored on init.outlive the posts it pointed at, and restoring it blindly would hide every
panel and leave an empty page.
localStoragethrows rather thanreturning null when a browser blocks storage, and a toggle that stops
working is a worse outcome than one that forgets.
Test plan
pnpm buildsucceeds, 82 pages, internal link check cleanpnpm lintcleanselected; clear the key and confirm it falls back to English