chore: one lint entry point, and a Makefile matching the sibling repos - #43
Merged
Conversation
`pnpm lint` meant eslint only, while the spacing and link checks hid under `check:*` here and `lint:*` in astro-sassify: the same scripts under two prefixes, and no single command that runs them all. - `lint` now runs every static check; the eslint call moves to `lint:eslint` - `check:spacing` and `check:links` become `lint:spacing` and `lint:links` - CI drops its separate spacing step, so a check added to `lint` runs there without editing the workflow - `lint` excludes the link check on purpose: that one reads dist/ and exits 1 without it, so it belongs to the build, which already runs it - Add a Makefile with the same targets and help output as the sibling repos
leinss
added a commit
that referenced
this pull request
Aug 19, 2026
#43) `pnpm lint` meant eslint only, while the spacing and link checks hid under `check:*` here and `lint:*` in astro-sassify: the same scripts under two prefixes, and no single command that runs them all. - `lint` now runs every static check; the eslint call moves to `lint:eslint` - `check:spacing` and `check:links` become `lint:spacing` and `lint:links` - CI drops its separate spacing step, so a check added to `lint` runs there without editing the workflow - `lint` excludes the link check on purpose: that one reads dist/ and exits 1 without it, so it belongs to the build, which already runs it - Add a Makefile with the same targets and help output as the sibling repos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
pnpm lintmeant eslint only, while the spacing and link checks hid undercheck:*here andlint:*in astro-sassify. The same scripts carried twodifferent prefixes across two repos, and no single command ran them all.
What changed
lintruns every static check. The eslint call moves tolint:eslint.check:spacingandcheck:linksare renamedlint:spacingandlint:links.lintnow runs in CIwithout editing the workflow.
lintdeliberately excludes the link check: it readsdist/and exits 1without it, so it belongs to the build, which already runs it.
Makefilewith the same targets and help output as the sibling repos,so
make help,make lint,make buildandmake cleanwork the same wayin each.
Test plan
make helplists the targetsmake lintpassespnpm buildsucceeds, 82 pages, 1842 internal links, none broken