Bump C++ standard to C++23 - #13
Merged
Merged
Conversation
OCS2_COPTS, OCS2_TEST_COPTS, and OCS2_ROS2_COPTS all now build at -std=c++23 instead of the previous c++14/c++17 split. Verified with a full bazel build //... and bazel test //... (32/32 tests pass) on GCC 13.3. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OCS2_COPTS,OCS2_TEST_COPTS,OCS2_ROS2_COPTSin bazel/ocs2_cxx_flags.bzl) from the previous C++14/C++17 split to-std=c++23across the board, and updates the accompanying comments in.bazelrcandocs2_pinocchio/ocs2_pinocchio_interface/BUILD.bazelto match.--cxxoptis set, so they stay on their own toolchain default.Test plan
bazel build //...— full build succeeds (9488 actions, only pre-existing-Wsign-compare/-Wunused-variablewarnings)bazel test //...— 32/32 tests pass