CI: build natively on Ubuntu and inside the devcontainer on arm64 - #9
Merged
Merged
Conversation
Split CI into two jobs so both supported environments are always built and tested: - native-ubuntu: builds and tests directly on the ubuntu-24.04 (x86_64) runner host, no container. - devcontainer-arm64: builds the .devcontainer image and runs the build and tests inside it via the devcontainer CLI on ubuntu-24.04-arm. This is the same linux/arm64 container Docker Desktop/Colima runs on Apple Silicon; hosted macOS runners can't run Docker, so this is how the Mac devcontainer path is covered. The devcontainer job keeps devcontainer.json's named cache volume as-is and seeds/exports it from the Actions cache as a tarball. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The off-diagonal loop compared rows[j] == row_i without checking j < nnzJacobian_, so for the last non-zero it read one element past the end of the sparsity arrays. On x86_64 the garbage value happened to differ from row_i; on aarch64 it matched, and the following cols[j] index tripped Eigen's bounds assert in ocs2_core_cppadcg (CppAdInterfaceNoParameterFixture.testModelGeneration). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split CI into two jobs so both supported environments are always built and tested:
The devcontainer job keeps devcontainer.json's named cache volume as-is and seeds/exports it from the Actions cache as a tarball.