Repository navigation
Fix project hash on Windows (paths with forward slashes) - #173
Merged
Merged
Conversation
JSON mode still stringified a Windows path with backslashes, so the golden hash tests failed on the Windows runner. Hash the python-mode dump and write paths with as_posix; posix hashes are unchanged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N7hYfMaQFqSMBtq9ZWJ3gV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: on the Windows runner two golden-hash tests failed, because the hash serialised
Path("/data/s1")with backslashes. PR #172'smode="json"change did not help, since pydantic stringifies a Windows path withstr().After:
project_hash()dumps in python mode and writes every path withas_posix(), so the hash is the same on every platform. Posix hashes are unchanged (golden tests pass locally).How: new
_hash_defaultjson fallback intrack2data/core/models.py. The Windows jobs only run on push to main, so the fix can only be confirmed there after merge.🤖 Generated with Claude Code
https://claude.ai/code/session_01N7hYfMaQFqSMBtq9ZWJ3gV
Generated by Claude Code