Repository navigation
Record archive insertion qualification and reconcile tracking - #1126
Merged
Merged
Conversation
This was referenced Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep archive insertion unchanged. Retain two measured insertion experiments and their counterexamples so future work can avoid repeating them, and close stale O30 tracking for the owned-input optimization already merged in #1122.
AG;DR
Decision and retained scope
9bf1aad510d843d1d6338fbdf23107a30d339730(Record shared-worker qualification and retain specialized pools #1125). Both hosts passed all 28 public construction fixture oracles and three focused optimized archive targets. The one-session screen uses three repetitions retaining two, with baseline/candidate/identical-baseline participants. All Linux shape medians are slower (+0.60% to +2.34%); apparent Mac gains largely track its unchanged-image control. Large tiny-case disagreement and every slower result remain in the evidence. Stop at that screen: no new full-root suite, sanitizer qualification or full three-session population is claimed.lower_boundplus hinted ancestor insertion as separate, unmeasured O27c. Preserve duplicate replacement, synthesized-directory state, direct-child counts, inode order and source ownership.Evidence and presentation
docs/benchmarks/archive-index-insertion-20261107.mdand its lossless 4,525,832-byte.json.gzcapsule, SHA-256ef0f035c7369a11f8191f9b46407b6682cfb93ce1190e70743172fd0ed360527.release-site.json; extend the large-file exception for this exact archive only. Positive and negative filename controls reject unrelated files, dates and suffixes.O30 tracking correction
Owned
OpenBytesinput transfer already merged in #1122 as0e95e191ba7d7ee3769217e7fbf82a825ff9b90d. Its exact push/main Test run 42276661524 completed successfully, including both operating systems, sanitizers, coverage, GCC, fuzzing, CI clang-tidy and policy checks. Remove the stale create-a-PR instruction; retain O30's original noisy Mac measurements and private-versus-public image limitations.Validation and dependencies
The exact six-file payload was copied with per-file SHA-256 verification into an independent Linux checkout at the current main base. Changed-file
pre-commit run --files ...passed withSKIP=clang-tidyas explicitly requested by the user; no local clang-tidy was run. All 32 existing release-site tests, configured report mapping, precise allowlist controls, gzip/JSON decoding andgit diff --checkpassed. Every payload hash remained unchanged after these checks. The release-site unit tests use their existing local renderer fixtures; no unpublished-report API preview was attempted.Normal signed commit
11926909998d762a29d9e32b972455b71cf10770and normal push completed; the signature verifies as good. This private clone has no automatic commit or push hooks configured, so no additional hook execution is claimed. The independent Linux changed-file checks above passed on the exact published bytes. This PR still requires its own current-head CI, separate from archived experiment qualification. Based directly on merged #1125/main; no open PR dependency, and no change to the preserved unqualified #992/#996/#997/#998 branches.