Repository navigation
Record rejected hinted archive ancestor insertion screen - #1129
Merged
Merged
Conversation
…blication' into perf/direct-language-json-storage
…e' into docs/o27c-hinted-ancestor-qualification
This was referenced Nov 7, 2026
This was referenced Nov 7, 2026
This was referenced Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep archive ancestor insertion unchanged. Record the final requested O27 mechanism and its complete counterexamples so future work does not repeat an unqualified Linux-only improvement.
AG;DR
Decision and isolated mechanism
lower_boundsupplies the existing position to hintedtry_emplace, with comparator equality and the stored-member strict-prefix invariant preserved.Results and qualification boundary
Evidence and publication
docs/benchmarks/archive-ancestor-hint-20261107.mdand its 115,195-byte.json.gz, SHA-2568359b99d815469270bbdb90aef7ec8dd11f9156ef37d6b7c5a879672badfaad7. All 53 UTF-8 source/raw/log record byte counts and SHA-256 hashes independently verify, preserving source/image identities, complete cases, copied controls and setup failure.Validation and dependencies
Normal signed commit
b1d92ee275f2c7a1c1f5308291d4149a3771636cand normal push succeeded with all configured hooks intact. Trunk, the exact changed-file policy/format gates, canonical Markdown table checks, release-site configuration, gzip decoding, all 53 record identities and diff checks pass; published payload hashes remain unchanged. No local clang-tidy executable ran.Based on #1128 head
081d5be6627d004f2983837d1221399559e36910, following #1127/#1126 to preserve overlapping tracking and site-publication changes. Merge the ready parent unchanged first, then synchronize and require this PR's own current main-context CI. Historical experiment logs do not substitute for its required checks. The four unique unqualified worker drafts remain untouched.The ancestry was synchronized and pushed through normal signed merges after CI found three narrow
evaluate.cclint issues in #1127 and the required Brotli byte-pointer cast annotation in #1128. This PR's own implementation/evidence payload is unchanged. The corrected current head requires its own full CI; successful ancestor or previous-head checks are not substituted. Healthy reachable collectors were not cancelled, and local clang-tidy was not run.Current main synchronization
#1128 merged unchanged as
1278c8943a6abd236a2f20e3937cc8e23a0f95a7. After automatic retargeting, synchronized this child with signed merge73de2769f5a06b45c1677de7cabc31d1169d0854and pushed immediately through normal hooks. Proved that the squash main tree, qualified parent334cc891and already-included parentd89fa1d7have identical full trees. Resolved two adjacent documentation conflicts from the child only after this proof; the complete resulting tree is exactly the previous62030d1dchild tree. Runtime and all frozen evidence bytes are unchanged. The earlier stacked Test success is early feedback only; this pushed head must pass its own new main-context checks and the predecessor exact-main Test must be healthy. No local clang-tidy was run.