Repository navigation
test(webui): give the first-screen wait the budget this file already sets - #26
Merged
modacker merged 1 commit intoNov 10, 2026
Merged
Conversation
…sets The file documents a 30s first-screen budget in FIRST_SCREEN_TIMEOUT_MS and uses it in six places. The two waits on #webui-root were left on Playwright's 5s default, and those two are the waits that decide whether the client booted at all: an empty #webui-root is what a client that has not rendered looks like, and "hidden" is what an empty div reports. This file's own header carries the measurement. On the macOS CI run of the whole webui group this case measured 26.7s with the shell still not up when the default deadline expired, against 12.0s for the same case on ubuntu. The same case is what fails the macOS and windows jobs of the main CI run, with the report that the locator resolved to an empty #webui-root fourteen times and a 5000ms timeout. Waiting to the budget the file already sets is what the six sibling waits do, and it stays bounded: the case still fails when the client does not boot. An injected wait on an element that never appears fails in 3s with the same element-not-found report, so the budget gives a slow client the room the product's own 30s wire deadline allows without hiding a real failure. The whole file passes with the change (4 passed). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file's own header carries the measurement this closes: on the macOS CI run of the whole webui group this case measured 26.7s with the shell still not up when the default deadline expired, against 12.0s for the same case on ubuntu.
The six sibling waits in the file already use
FIRST_SCREEN_TIMEOUT_MS(30s). The two waits on#webui-rootwere left on Playwright's 5s default — and those two are the waits that decide whether the client booted at all, because an empty#webui-rootis exactly what a client that has not rendered looks like, andhiddenis what an empty div reports.Measured on the main CI run
42817291871: the macOS job fails this case with the locator resolving to an empty#webui-rootfourteen times and a 5000ms timeout. The same case is what fails the webui group locally on a loaded Windows host (1 failed | 4462 passed | 44 skipped).The budget stays bounded. The case still fails when the client does not boot: an injected wait on an element that never appears fails in 3s with the same element-not-found report, so the extra room is given to a slow client, not to a broken one.
No product code is touched. This is the test's own budget, used the same way six lines above already use it.