Skip to content

test(webui): give the first-screen wait the budget this file already sets #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
modacker merged 1 commit into from
Nov 10, 2026
Merged

test(webui): give the first-screen wait the budget this file already sets #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/webui/test/integration/agent-transcript.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,7 @@ it.each(["transcript", "cross-client", "external-active-mutation", "external-act
await page.context().grantPermissions(["clipboard-read", "clipboard-write"], {
origin: new URL(url).origin,
});
await browserExpect(page.locator("#webui-root")).toBeVisible();
await browserExpect(page.locator("#webui-root")).toBeVisible({ timeout: FIRST_SCREEN_TIMEOUT_MS });
// The event channel opens as the client boots, so this wait is bounded by
// the boot budget the file already documents — not by the default 5s, which
// a loaded runner can pass without the client having started at all.
Expand Down Expand Up @@ -859,7 +859,7 @@ it.each(["transcript", "cross-client", "external-active-mutation", "external-act
// message is part of that condition: it can only be on screen once the
// reloaded client has resumed the session and rendered what it read back.
await browserExpect(composer).toBeVisible({ timeout: FIRST_SCREEN_TIMEOUT_MS });
await browserExpect(page.locator("#webui-root")).toBeVisible();
await browserExpect(page.locator("#webui-root")).toBeVisible({ timeout: FIRST_SCREEN_TIMEOUT_MS });
await browserExpect(page.getByText("Please reason, then answer.")).toBeVisible();
try {
await browserExpect.poll(() => requests.filter((request) => request.operation === "resumeSession").length)
Expand Down
Loading