Enable generic sandbox kernel capabilities - #113
Open
Enrique Saurez (esaurez) wants to merge 1 commit into
Open
Enrique Saurez (esaurez) wants to merge 1 commit into
Enrique Saurez (esaurez) wants to merge 1 commit into
Conversation
Copilot started reviewing on behalf of
Enrique Saurez (esaurez)
September 18, 2026 16:49
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The capability and validation changes are complete; the remaining diagnostic wording issue is minor.
Pull request overview
Enables and validates generic kernel capabilities required by sandbox workloads.
Changes:
- Enables Unix sockets and seccomp filtering.
- Disables unconditional overlayfs redirect following.
- Extends build, release, test, and documentation validation.
File summaries
| File | Description |
|---|---|
kernel/config-microvm |
Enables required kernel capabilities. |
scripts/nvx_tools/build.py |
Adds capabilities to build-time validation. |
scripts/nvx_tools/release.py |
Validates source and generated configurations. |
scripts/test_nvx_tools.py |
Tests every required setting. |
doc/build.md |
Documents the capability contract. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Copilot started reviewing on behalf of
Enrique Saurez (esaurez)
September 18, 2026 17:17
View session
Enrique Saurez (esaurez)
marked this pull request as ready for review
September 18, 2026 17:18
Define the microVM kernel options required by generic sandbox workloads as a shared build and release contract. Require seccomp filtering and safe overlayfs redirect behavior, and preserve the existing Unix-domain socket setting alongside the filesystem, memory-cgroup, and virtio block requirements. Fail kernel builds when olddefconfig drops any required option. Reuse the same requirement list when verifying checked-in sources and generated release artifacts so configuration drift is caught consistently. Expand unit coverage to remove each required setting in turn and document the resulting kernel contract. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 54ea5030-072c-440a-87f8-f607431664b8
Pedro Henrique Penna (ppenna)
force-pushed
the
esaurez/nvx-platform/01-kernel-20260918
branch
from
September 18, 2026 18:51
0116efe to
92519ca
Compare
Copilot started reviewing on behalf of
Enrique Saurez (esaurez)
September 18, 2026 18:51
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The generated-config release validation lacks direct unit-test coverage.
Get a fresh assessment by requesting another Copilot review.
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Balanced
| for setting in ( | ||
| "CONFIG_PVH=y", | ||
| "CONFIG_HVC_XE9=y", | ||
| *REQUIRED_SANDBOX_KERNEL_CONFIG, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable the generic Linux kernel capabilities required by sandbox workloads without selecting or embedding a product-specific guest agent.
Main changes
Rationale
NVX owns the Linux kernel configuration distributed to downstream products. Keeping these workload capabilities and their validation in NVX prevents product build systems from patching or weakening the kernel configuration independently.
The existing OpenVMM gitlink from
devis unchanged.