Repository navigation
feat(play): a play page, the activity alone for a chat app's card - #87
Merged
Merged
Conversation
/h5p/play/#source=… builds the source in the browser as the build page does and plays it, with only its download and a way to the build page beside it. Framed, it tells its parent its height and gives it the built file. No page links to it; it is not in the sitemap.
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
…d, the README row whole (#86)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #86.
/h5p/play/#source=…is the activity on its own, for a chat app's card (missing-elements/h5p-toolkit#210). It builds the source in the browser just as the build page does, reusingbuild-source.tsand the same packages, and shows only the player, Download the .h5p, and Open in the build page.Inside a frame, it posts two messages to its parent:
.h5pfile, which the card can save its own way, since a host's sandbox may block a download from a frame.A source with problems, or one that names files of the person's own, gets one sentence and the link to the build page, where those are handled.
Checked:
pnpm buildpasses.https://missing-elements.github.io/h5p/play/.Summary by cubic
Adds
/h5p/play/, a page that builds an H5P activity from the#source=in its link and plays it alone, for a chat app to embed in its reply as a frame. Closes #86.New Features
.h5pfile to the parent, since a host's sandbox may block a frame download.Written for commit 4fd4ace. Summary will update on new commits.