Repository navigation
feat(devcontainer)!: start from the base image; drop the published image - #45
Merged
Merged
Conversation
The dev container now builds directly from mcr.microsoft.com/devcontainers/base:ubuntu-24.04. mise comes from a local Feature (.devcontainer/features/mise/) that installs the pinned release with no api.github.com call and puts the mise shims on PATH. The lifecycle scripts move to .devcontainer/scripts/. Removed: .devcontainer/image/ (Dockerfile, its config and lockfile), release-please, release.yaml, the release-tags ruleset, version.txt, CHANGELOG.md, .repo/outputs.toml and hadolint. The image was never published. Added: corepack for pnpm/yarn, an opt-in Rust Feature, and commented mise pins for OpenTofu, tflint, terraform-docs, doctl, cloudflared and buf. CONFIGURATION.md and LAYOUT.md move to docs/. Decision 0004 supersedes 0001 and 0003. DEVC-03 is waived for the local Feature (musher-dev/engineering-conventions#106). BREAKING CHANGE: ghcr.io/musher-dev/development-container is no longer published; a repository copies the template's .devcontainer/ instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 14, 2026
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcr.microsoft.com/devcontainers/base:ubuntu-24.04. The lifecycle scripts move to.devcontainer/scripts/..devcontainer/features/mise/:min_version) with noapi.github.comcall.devcontainers-extra/features/miseresolves every version through the API without authentication, so it isn't used.verify-toolchain.shfails if the Feature's version andmin_versiondiffer..devcontainer/image/release.yamland the release-tags rulesetversion.txt,CHANGELOG.mdand.repo/outputs.tomlpackageManagerCONFIGURATION.mdandLAYOUT.mdmove todocs/. Decision 0004 supersedes 0001 and 0003.Test plan
task check: lint,repo check, 45 tests,conventions check --fail-on warningwith no findings.devcontainer/**/*.shdevcontainer up --frozen-lockfileplus a full post-create, twice.verify-toolchain.shpasses (mise 2026.8.6, every pin installed),pnpm --versionreturns 10.33.0 through corepack, and task and uv resolve from the shims the Feature puts on PATHFollow-ups outside this repository
RELEASE_APP_*variables and secrets, and the release App's tag bypass, are now unused..repo/governancepolicies and the env tools upstream.🤖 Generated with Claude Code