Skip to content

Update of-watchdog to 0.12.2 - #79

Open
welteki wants to merge 1 commit into
openfaas:masterfrom
welteki:update-of-watchdog
Open

welteki wants to merge 1 commit into
openfaas:masterfrom
welteki:update-of-watchdog

Conversation

@welteki

@welteki welteki commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

Description

Update of-watchdog from 0.11.6 to 0.12.2 in all five Python Flask and HTTP template Dockerfiles.

Motivation and Context

Add support for built-in OAuth2/OIDC browser login in the Python templates and include the latest of-watchdog fixes.

  • I have raised an issue to propose this change (required)
  • My issue has received approval from the maintainers or lead with the design/approved label

How Has This Been Tested?

  1. Built all five templates locally with Docker on Linux/amd64, using docker build --build-arg TEST_ENABLED=true for the four Python 3 templates and docker build for python27-flask.
  2. Verified the existing Python 3 lint and test commands passed during each build.
  3. Started each image, waited for the application to respond, and verified /_/health and a POST invocation returned HTTP 200 with the expected response.
  4. Verified fwatchdog -version reports 0.12.2 in every image.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@reviewfn

This comment has been minimized.

@welteki
welteki marked this pull request as ready for review September 24, 2026 14:32
@reviewfn

This comment has been minimized.

@welteki welteki changed the title Update of-watchdog to 0.12.1 Update of-watchdog to 0.12.2 Sep 28, 2026
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
@reviewfn

reviewfn Bot commented Sep 28, 2026

Copy link
Copy Markdown

AI Pull Request Overview

Disclaimer: This review was generated by automated AI and may contain errors. Do not trust its outputs without human verification.

Summary

  • Updates ghcr.io/openfaas/of-watchdog from 0.11.6 to 0.12.2 across all five scoped Python template Dockerfiles.
  • The change is limited to Dockerfile base image tags for the watchdog stage.
  • No template command, environment, user, healthcheck, dependency, or application wiring changes are included.
  • The Python 3 templates keep their existing TARGETPLATFORM handling for the watchdog and Python image stages.
  • No blocking correctness, security, or migration issue was identified from the scoped diff.

Approval rating (1-10)

9/10. The scoped change is narrow and consistent; remaining risk is limited to runtime behavior of the upgraded watchdog image.

Summary per file

Summary per file
File path Summary
template/python27-flask/Dockerfile Bumps watchdog image tag to 0.12.2.
template/python3-flask-debian/Dockerfile Bumps platform-scoped watchdog image tag to 0.12.2.
template/python3-flask/Dockerfile Bumps platform-scoped watchdog image tag to 0.12.2.
template/python3-http-debian/Dockerfile Bumps platform-scoped watchdog image tag to 0.12.2.
template/python3-http/Dockerfile Bumps platform-scoped watchdog image tag to 0.12.2.

Overall Assessment

The PR is a focused infrastructure/template update and applies the watchdog version bump consistently across the scoped Dockerfiles. The surrounding Dockerfile behavior remains unchanged, including the existing HTTP mode environment, healthcheck, non-root user setup, and multi-platform handling in the Python 3 templates. I did not identify a concrete defect or regression in the final scoped diff.

Detailed Review

Detailed Review

No blocking findings.

The scoped diff only changes the ghcr.io/openfaas/of-watchdog image tag from 0.11.6 to 0.12.2 in each affected Dockerfile. The version is updated consistently across the five templates named in the PR description, and the copy path remains /fwatchdog, which matches the existing template contract.

The Python 3 Dockerfiles retain --platform=${TARGETPLATFORM:-linux/amd64} on both the watchdog and Python base stages, so this change does not introduce an architecture mismatch in those templates. The Python 2.7 template keeps its pre-existing unscoped FROM ghcr.io/openfaas/of-watchdog:... form; since this PR only changes the tag, that is not a new defect in the scoped diff.

AI agent details.

Agent processing time: 1m1.33s
Environment preparation time: 3.244s
Total time from webhook: 1m7.318s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant