Skip to content

Update of-watchdog to 0.12.2 - #79

Open
welteki wants to merge 1 commit into
openfaas:masterfrom
welteki:update-of-watchdog
Open

Update of-watchdog to 0.12.2#79
welteki wants to merge 1 commit into
openfaas:masterfrom
welteki:update-of-watchdog

Update of-watchdog to 0.12.2

97357b0
Select commit
Loading
Failed to load commit list.
reviewfn / AI Code Review succeeded Sep 28, 2026 in 1m 5s

AI Code Review Results

AI Pull Request Overview

Disclaimer: This review was generated by automated AI and may contain errors. Do not trust its outputs without human verification.

Summary

  • Updates ghcr.io/openfaas/of-watchdog from 0.11.6 to 0.12.2 across all five scoped Python template Dockerfiles.
  • The change is limited to Dockerfile base image tags for the watchdog stage.
  • No template command, environment, user, healthcheck, dependency, or application wiring changes are included.
  • The Python 3 templates keep their existing TARGETPLATFORM handling for the watchdog and Python image stages.
  • No blocking correctness, security, or migration issue was identified from the scoped diff.

Approval rating (1-10)

9/10. The scoped change is narrow and consistent; remaining risk is limited to runtime behavior of the upgraded watchdog image.

Summary per file

Summary per file
File path Summary
template/python27-flask/Dockerfile Bumps watchdog image tag to 0.12.2.
template/python3-flask-debian/Dockerfile Bumps platform-scoped watchdog image tag to 0.12.2.
template/python3-flask/Dockerfile Bumps platform-scoped watchdog image tag to 0.12.2.
template/python3-http-debian/Dockerfile Bumps platform-scoped watchdog image tag to 0.12.2.
template/python3-http/Dockerfile Bumps platform-scoped watchdog image tag to 0.12.2.

Overall Assessment

The PR is a focused infrastructure/template update and applies the watchdog version bump consistently across the scoped Dockerfiles. The surrounding Dockerfile behavior remains unchanged, including the existing HTTP mode environment, healthcheck, non-root user setup, and multi-platform handling in the Python 3 templates. I did not identify a concrete defect or regression in the final scoped diff.

Detailed Review

Detailed Review

No blocking findings.

The scoped diff only changes the ghcr.io/openfaas/of-watchdog image tag from 0.11.6 to 0.12.2 in each affected Dockerfile. The version is updated consistently across the five templates named in the PR description, and the copy path remains /fwatchdog, which matches the existing template contract.

The Python 3 Dockerfiles retain --platform=${TARGETPLATFORM:-linux/amd64} on both the watchdog and Python base stages, so this change does not introduce an architecture mismatch in those templates. The Python 2.7 template keeps its pre-existing unscoped FROM ghcr.io/openfaas/of-watchdog:... form; since this PR only changes the tag, that is not a new defect in the scoped diff.

AI agent details.

Agent processing time: 1m1.33s
Environment preparation time: 3.244s
Total time from webhook: 1m7.318s
View more details on reviewfn