Repository navigation
Complete Asher Selichoth services through the final circumcision pizmon - #69
Draft
EfraimFeinstein wants to merge 82 commits into
Draft
EfraimFeinstein wants to merge 82 commits into
EfraimFeinstein wants to merge 82 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This project PR supplies the Hebrew and English JLPTEI book modules and service assemblies, including the corrected first-day poems.
Asher’s 1912 Selichoth is encoded through its final page, Archive n410 (printed 204), with bilingual title metadata, reusable prayer and piyyut modules, source-independent URNs, facsimiles, verse/prose structure and apparatus. Documentary and expanded views share modules; supplied text replaces fulfilled inclusion instructions while performance rubrics remain.
The Hebrew second image pass reaches the final Hebrew page, s410/n409 (printed204). English image proofreading now covers the English title, first seven days, Erev Rosh Hashanah and Tzom Gedaliah, s3/n2 and s7/n6–s209/n208, with frozen scan readings, pre-edit snapshots, comparisons and adjudication under
sources/asher_selichot/proofreading/english-pass-01/throughenglish-pass-09/. This is a same-model second pass with prior exposure, not independent-person proofreading. Erev Rosh Hashanah has 43 frozen page readings, 50 image-adjudicated token corrections, 44 validated XML files and 113 reverse-verified service units. Tzom Gedaliah is now complete with 13 frozen readings, 10 corrections, 32 validated XML files and 38 reverse-verified units. Next is the second penitential day.English corrections follow each page's printed wording and punctuation, including printed errors rather than silent modernization. The third-day printed31/32 sequence is preserved despite swapped Archive leaves. Numeral-inclusive audits found no additional first/second-day differences. One damaged fourth-day punctuation mark and the fifth-day Noachic/Noachie ending remain uncertain. Sixth-day review removed an unprinted English refrain cue and its unsupported expansion.
Each completed English service passes XML validation, documentary reverse comparison and expansion verification. Both service-only PDFs pass footnote occurrence, stanza alignment, direction, contents, bookmarks and boundary checks with deliberately broken controls. Latest Tzom Gedaliah PDFs: 26 documentary/53 expanded pages; eight stanza starts, four petition expansions, all 18 English notes and the Hebrew marginal note checked. Erev Rosh Hashanah’s Tamid 1–26 remain unresolved printed markers without accompanying apparatus on its source pages. The first-day inspection also checks the date context that suppresses the Ten Days Kaddish addition.
Prior whole-book validation passes all398 XML files and all service source comparisons and expansion boundaries. The last full suite passed3,557 tests with12 skips (732.140 seconds); no generic executable logic changed during these English checkpoints, so it has not been rerun for declarative text corrections. Whole-book PDFs (311/680 pages) remain earlier snapshots; current service inspection artifacts stay untracked under
output/asher_selichot/.Remaining work includes later English services, independent-person review, uncertain Hebrew pointing and title ink, the final English superscript, and the recorded mixed-language footnote paragraph-separation issue. Publication and automatic release integration remain outside this work.
Companion PRs: opensiddur/opensiddur-ai#215, opensiddur/sourcetexts#49, #69. Further proofreading stays on these branches.