fix: load agent contribution and review guidance - #11
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟢 Approval recommended
Changes are straightforward configuration/automation updates with pinned actions and no detected behavioral impact on apps, data, or deployment.
Pull request overview
This PR aligns Claude’s entrypoint and repo automation with the shared Origin89 contribution/review rules by importing @AGENTS.md, exposing the verified skills snapshot in both expected discovery locations, and adding a pinned metadata-only contribution check workflow.
Changes:
- Point
CLAUDE.mddirectly at@AGENTS.mdand extendAGENTS.mdto require loading the commits/PR skill before branch/commit/push/PR operations. - Update the engineering skill sync to populate both
.agents/skillsand.claude/skillsdiscovery paths, and ignore the new.claudeskill links. - Add a pinned
Contributionworkflow for PR metadata checks and tighten the Claude review workflow prompt to include the commits skill; simplify the PR template.
File summaries
| File | Description |
|---|---|
| CLAUDE.md | Switches Claude’s entry file to import the repo’s shared instruction file via @AGENTS.md. |
| AGENTS.md | Adds explicit requirement to load the commits/PR skill before branch/commit/push/PR actions. |
| .origin89/sync-engineering.py | Mirrors skill discovery symlinks into .claude/skills in addition to .agents/skills. |
| .gitignore | Ignores the managed .claude/skills/origin89-* symlinks like the existing .agents ones. |
| .github/workflows/contribution.yml | Adds pinned, metadata-only PR contribution workflow on pull_request_target. |
| .github/workflows/claude-code-review.yml | Updates the review prompt to include origin89-commits alongside working/review skills. |
| .github/pull_request_template.md | Replaces the verbose template with a concise “Change / Validation” structure plus guidance comments. |
| .claude/settings.json | Disables default attribution for Claude via repo settings. |
Review details
- Files reviewed: 7/8 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lemarier
changed the title
Change
Import
AGENTS.mdautomatically in Claude, expose verified shared skills through.claude/skills, disable default attribution, and load the commit/PR skill in the existing Claude review workflow. Add native Codex and Copilot review instructions for provenance, authorization, resource bounds, and data loss.Use the shorter PR template from engineering #1. Merge that PR first so the next skills refresh can load the updated guidance. Hosted reviews use local rules without running the refresh.
Validation
just checkpassed: 151 root tests, 150 Worker tests, Biome, type checks, record validation, site build, and two matching 35-file dataset builds. Actionlint passed for the changed Claude workflow. An offline consumer smoke test preserved project skills and exposed both discovery paths; engineering's 30 regression tests passed.