ci: avoid duplicate checks on pull requests - #10
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6f26b8df69
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| on: | ||
| push: | ||
| branches: [$default-branch] |
There was a problem hiding this comment.
When an adopting repository has a valid default branch containing a YAML flow delimiter, such as release,v2, the documented substitution produces branches: [release,v2], which YAML interprets as two separate branch filters. The workflow then skips the intended default-branch push, eliminating the post-merge check this change promises; quote the placeholder and render/lint a valid nontrivial branch name.
AGENTS.md reference: AGENTS.md:L13-L16
Useful? React with 👍 / 👎.
The shared package-check template starts both push and pull-request runs for the same PR update. Restrict its push trigger to the adopting repository's default branch and document the trigger policy. Keep PR checks and manual release-PR checks available.
Validation: rendered the template for main, checked it with actionlint 1.7.12, verified the trigger cases, and passed
just check.